[29.0] Composite Report Parts: seed via a report extension instead of install/upgrade code

[MSlenejennum]

Summary

• Replaces the SeedPart-based install/upgrade seeding of the shipped header/footer designs and report themes with a declarative report extension (CompositeLayout.reportExt.al, extending "Tenant Report Defaults") that lists all 14 parts as layout() entries.
• Removes "Composite Report Parts Mgt.", "Upgrade Composite Report Parts", the per-database upgrade tag (W1/BE/IT/RU), the BaseApp Install seeding trigger, and the composite-report-part tests added to CompositeLayoutTests — none of it is needed once the platform registers the layouts natively instead of the app writing them into Tenant Report Layout itself.
• Moves the 14 part resource files from .resources/ReportParts/ to Foundation/Reporting/ReportParts/, alongside the report extension that references them via LayoutFile.

This is a [29.0] backport of the same rework applied on main in #11137.

AB#649843

Test plan

• Build the affected app(s) locally with no new analyzer warnings.
• Confirm in Business Central that all 14 External/Internal Header & Footer Designs and Report Themes show up under "Tenant Report Defaults" via the Composite Layout report extension.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This PR adds shipped composite report header/footer designs and report themes, then seeds them under Tenant Report Defaults during install, upgrade, and company open. The main flow is targeted, the resource names in the seeding code match the shipped files, and the tests cover the normal seeding path and minimal-permission company-open path. The remaining problem is the completion marker: the code can still record the database tag even when one or more parts were not written.

Problem-solution fit

Fit: Partial

The change delivers the requested seeded parts and includes a clear install/upgrade path. It does not fully protect the persistent state when a part fails to seed, because the database can be marked as complete while shipped content is missing.

Suggestions

S1 (🔴 High): Do not mark failed seeding complete
Only set the database upgrade tag after all shipped parts are written. SeedDefaultParts() logs a bad resource and returns, so the current code can mark the database as complete while a part is missing and no later install, upgrade, or company-open run will retry it.

Risk assessment and necessity

Risk: The regression surface is the shared Tenant Report Defaults pool and the install, upgrade, and company-open seeding paths. If the tag is set after a partial seed, a tenant can stay permanently missing a shipped theme or header/footer design until a later dedicated upgrade step fixes it.

Necessity: The backport is needed so the composite report parts are available on 29.0. The scope is right, but the tag must mean that the full seeding step completed.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11126 round=1 by=alexei-dobriansky at=2026-09-07T22:20:30Z lastSha=f80d761b73127303d2f6999be22ab176db53d99d reviewKey=9cf1f88b956f148503fe653a64ae4ae871dd4c273d348aa0f3c80c3cf48cb7fe suggestions=S1@caa5ec98

[alexei-dobriansky]

Good Sense Reviewer - Round 2

Recommendation: Request Changes

What this PR does

This round changes the seeding flow so SeedDefaultParts() returns whether all shipped parts were seeded, and SeedShippedParts() writes the completion tag only after a full pass. That fixes the direct tag write, but the same tag is still registered for automatic per-database stamping, so another path can still mark the database complete without a successful seed.

Status of previous suggestions

ID	Title	Status	Author response
S1	Do not mark failed seeding complete	Not addressed	The direct tag write now checks the full-pass result, but SetAllUpgradeTags() can still write the registered per-database tag independently of the seed result.

New observations (commits since round 1)

None beyond the still-open previous suggestion.

Risk assessment and necessity

Risk: The regression surface is the shared Tenant Report Defaults pool and install, upgrade, and company-initialization paths. If one shipped resource cannot be read, automatic tag stamping can make later install, upgrade, or company-open runs exit before retrying, leaving a shipped part missing.

Necessity: The backport is needed so the composite report parts are available on 29.0. The scope is right, but the completion tag must only mean that all shipped parts were seeded.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11126 round=2 by=alexei-dobriansky at=2026-09-08T22:08:34Z lastSha=5991e0d80d79f4ffed778f12044d6031496c76f5 reviewKey=554ae7c88666af8cb51bf2290c8956603d4f0e7df1b9660a0785e8a9155a94a3 suggestions=S1@caa5ec98:notaddressed parentRound=1

[alexei-dobriansky]

Good Sense Reviewer - Round 3

Recommendation: Accept

What this PR does

This round replaces the app-owned seeding approach with a declarative report extension for Tenant Report Defaults. The extension lists all shipped report themes and header/footer designs as layout entries, and each LayoutFile path points to a file added by the change. Because the current net diff no longer writes Tenant Report Layout records or registers a completion upgrade tag, the earlier partial-seed completion risk is removed.

Status of previous suggestions

ID	Title	Status	Author response
S1	Do not mark failed seeding complete	Addressed	The current change no longer contains the seeding code or the per-database tag path that could mark a partial seed as complete.

New observations (commits since round 2)

None - the current force-pushed change addresses the previous blocker without adding a new review finding.

Risk assessment and necessity

Risk: The regression surface is now the platform registration of report extension layouts and the packaging of the 14 shipped files. If a path or file is wrong, a shipped theme or header/footer design would be missing, but there is no longer an install, upgrade, or company-open database write path that can leave a false completion marker behind.

Necessity: The change is needed so the shipped composite report parts are available on 29.0. The scope is narrow: it registers the shipped parts declaratively and removes the need for app-owned seeding behavior.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11126 round=3 by=alexei-dobriansky at=2026-09-11T13:10:24Z lastSha=623577ced81e0dee8199f5caf992c7a08471c586 reviewKey=b13db5f45cc45a5f4c7d70b38f34a056d633a8e105cd01d40a63888f652c3d62 suggestions=S1@caa5ec98:addressed parentRound=2

[alexei-dobriansky]

Good Sense Reviewer - Round 4

Recommendation: Accept

What this PR does

The new commit removes local-machine references from the packaged header and footer design files. The declarative registration approach reviewed in the previous round is unchanged.

Status of previous suggestions

ID	Title	Status	Author response
S1	Do not mark failed seeding complete	Addressed	The old seeding and completion-tag path remains removed.

New observations (commits since round 3)

None - the new commit only cleans metadata inside the shipped document templates.

Risk assessment and necessity

Risk: The incremental change is limited to packaged document binaries. A malformed template could affect a shipped design, but it does not reintroduce the database seeding risk.

Necessity: Removing local-machine references makes the shipped templates portable and is an appropriate final cleanup.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11126 round=4 by=alexei-dobriansky at=2026-09-14T22:31:00Z lastSha=928d10b8fb651d8c5872542ec0dbcc8ad6c17660 reviewKey=047f877fe334cb21efceff4d13f04d8f199dfec1570badd241f1d351f22c4cea suggestions=S1@caa5ec98:addressed parentRound=3

[Predrag Maricic (PredragMaricic)]

Recommendation: Request Changes

S1 - Restore the actual External Default template

ExternalDefault.docx and ExternalDefaultDetailed.docx are byte-identical (3f0b469a...). The ordinary External Default therefore renders the detailed design, including bank account, giro, and VAT controls, despite its summary promising only contact details. The merged source PR has distinct blobs, and its ordinary template omits all 16 detailed-only bindings. Backport the final source assets rather than registering the duplicated file.

S2 - Link the work item for this feature backport

AB#649843 is the unrelated stress-test bug delivered by PR #11331; its title and repro cover duplicate names, layout status, empty uploads, and part resolution. It does not track introducing the 14 shipped parts through PR #11137. Link the actual 29.0 feature/backport item so validation and servicing traceability point to this change.

S3 - Validate registration and rendering of all shipped parts

This PR introduces 14 platform-registered binary layouts but adds no focused test, and both manual test-plan items remain unchecked. Existing CI is fully green but does not prove that the parts appear under Tenant Report Defaults or render as their declared variants - the duplicated External Default passed all 166 checks. Add automated registration assertions where feasible and record runtime rendering validation for all distinct designs.

The declarative AL file is otherwise byte-identical to the merged source implementation, all referenced resources exist, and the previous imperative-seeding risks are no longer present.

[Predrag Maricic (PredragMaricic)]

Verified the backport against #11137: the report extension and all 14 layout assets are blob-identical to the merged source. The previously duplicated External Default asset is corrected. No blocking findings.

[alexei-dobriansky]

Good Sense Reviewer - Round 5

Recommendation: Accept

What this PR does

The new commit refreshes the shipped header/footer design files and the Calm theme to match the already merged main-branch version. The declarative Tenant Report Defaults registration is unchanged, all LayoutFile paths still point to files in the PR, and the earlier seeding and completion-tag risk remains removed.

Status of previous suggestions

ID	Title	Status	Author response
S1	Do not mark failed seeding complete	Addressed	The old seeding and completion-tag path remains removed; the new commit only updates packaged template files.

New observations (commits since round 4)

None - the new commit only syncs packaged templates with the main version and does not change AL logic.

Risk assessment and necessity

Risk: The incremental regression surface is limited to the packaged Word template files used by the shipped themes and header/footer designs. A bad template could make one shipped design unusable, but the layout registrations still reference existing files and the updated blobs match the main-branch version.

Necessity: The backport remains needed so the shipped composite report parts are available on 29.0 through platform registration. Syncing the template files keeps the release branch aligned with the already accepted main-branch content without reintroducing app-owned seeding behavior.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11126 round=5 by=alexei-dobriansky at=2026-09-20T22:13:50Z lastSha=423b3fa3f213523827cc9ba2f905b63219fd971c reviewKey=59085c6002f9922861f63fb0d04137eb3cd6ec475cd9b00eceff0797cf27a04e suggestions=S1@caa5ec98:addressed parentRound=4

[alexei-dobriansky]

Good Sense Reviewer - Round 6

Recommendation: Request Changes

What this PR does

The new commit merges the release branch and bumps the BCPlatform package version to 29.0.54748.0. The declarative Tenant Report Defaults registration is unchanged, and the old seeding and completion-tag path remains removed. The package bump is not safe yet because the current app build fails with AL0133 DotNet conversion errors for IAzureKeyVaultSecretProvider.

Status of previous suggestions

ID	Title	Status	Author response
S1	Do not mark failed seeding complete	Addressed	The old seeding and completion-tag path remains removed; this round only merges the release branch and changes the platform package version.

New observations (commits since round 5)

S2 (🔴 High): Do not merge platform bump that breaks builds
The BCPlatform bump to 29.0.54748.0 makes the app build fail with AL0133 DotNet conversion errors for IAzureKeyVaultSecretProvider. Either include the matching source/mock update with this bump or use a platform version that builds the current apps. Until this compiles, the PR cannot be safely merged.

Risk assessment and necessity

Risk: The incremental regression surface is the shared platform package used by every app build. A broken platform bump blocks release validation before the report-layout change can be safely consumed.

Necessity: The backport remains needed so shipped composite report parts are available on 29.0 through platform registration. A newer platform package is only safe when the repo also contains any source or mock updates needed to compile against that package.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11126 round=6 by=alexei-dobriansky at=2026-09-21T22:09:12Z lastSha=d07a9327e95cb64ad348ec055eb6754d2b3b6da8 reviewKey=e5ce3229e72db77e50c2f4ae551165212a759c2e1ceb0e26ba211bb8fd8ce16d suggestions=S1@caa5ec98:addressed,S2@68528be8:new parentRound=5