Repository navigation
fix(agent): observe a control again only after it stops being busy - #978
Conversation
A button that disables itself for the request was snapshotted while it was still disabled, so the run ended before the result appeared. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58f51ac. Configure here.
A hidden aria-busy flag or a progress meter with a value is not an in-flight request, so settle no longer waits on it. The check also walks shadow roots. Co-authored-by: Cursor <cursoragent@cursor.com>
The page double treats an unrecognized evaluate as the next observation, so the idle check was consuming the state the following decision was supposed to see. Co-authored-by: Cursor <cursoragent@cursor.com>
|
coverage: 77.415% (-0.2%) from 77.569% — fix/agent-busy-settle into master |
Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Summary
aria-busyor shows a progress bar, was observed in the middle of that work.Test plan
pnpm exec ava test/chrome.js -m '*disables itself*'Made with Cursor