Implement play-services-asterism - #3360
Open
opstic wants to merge 52 commits into
Open
Conversation
This was referenced Mar 24, 2026
|
Complementary PR submitted: #3596 (#3596) This PR adds two critical bug fixes on top of the Constellation/Asterism implementation:
These address the bugs identified by unpluggederan in issue #2994 comments. |
|
Quick update: I submitted a complementary fix PR (#3596) but @mar-v-in correctly pointed out it duplicates #3360 since the timeout and callback fixes are already in this PR. Closing #3596. The two critical bugs mentioned by @unpluggederan are already addressed:
Remaining issue from @unpluggederan's last comment:
I'm investigating this DroidGuard attestation path next. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 2 of 2 towards RCS support.
Related PR: #3359
Related issue: #2994
Depends on #3359 (Note: Until it's merged, this PR will include its commits in the diff)
Description
This PR implements the Asterism service, including:
getAsterismConsentsetAsterismConsentgetIsPnvrConstellationDeviceThis PR uses gRPC proto definitions and client implementation introduced in
play-services-constellation(PR #3359)