Skip to content

Implement play-services-asterism - #3360

Open
opstic wants to merge 52 commits into
microg:masterfrom
opstic:asterism
Open

Implement play-services-asterism#3360
opstic wants to merge 52 commits into
microg:masterfrom
opstic:asterism

Conversation

@opstic

@opstic opstic commented Mar 24, 2026

Copy link
Copy Markdown

This is PR 2 of 2 towards RCS support.
Related PR: #3359
Related issue: #2994

Depends on #3359 (Note: Until it's merged, this PR will include its commits in the diff)

Description

This PR implements the Asterism service, including:

  • getAsterismConsent
  • setAsterismConsent
  • getIsPnvrConstellationDevice

This PR uses gRPC proto definitions and client implementation introduced in play-services-constellation (PR #3359)

@mar-v-in mar-v-in linked an issue Jun 7, 2026 that may be closed by this pull request
@mar-v-in mar-v-in linked an issue Jun 7, 2026 that may be closed by this pull request
@chenlinxi890-spec

Copy link
Copy Markdown

Complementary PR submitted: #3596 (#3596)

This PR adds two critical bug fixes on top of the Constellation/Asterism implementation:

  1. gRPC timeout fix: Added connectTimeout/writeTimeout/callTimeout (60s) — only readTimeout was set
  2. DeadObjectException fix: Wrapped callbacks.onPhoneNumber* in try-catch

These address the bugs identified by unpluggederan in issue #2994 comments.

@chenlinxi890-spec

Copy link
Copy Markdown

Quick update: I submitted a complementary fix PR (#3596) but @mar-v-in correctly pointed out it duplicates #3360 since the timeout and callback fixes are already in this PR. Closing #3596.

The two critical bugs mentioned by @unpluggederan are already addressed:

  1. ✅ gRPC timeout fix — commit 309566d (Set timeout on the right place)
  2. ✅ DeadObjectException fix — commit 2ec6d36 (Wrap callbacks in try catch)

Remaining issue from @unpluggederan's last comment:

  • Tachygram/DroidGuard attestation failures causing RCS to show 'Connected' but not actually work

I'm investigating this DroidGuard attestation path next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BOUNTY] RCS Support [14999$]

3 participants