Skip to content

CI/CD Pipeline False Positives: import-dir Exits with Code 0 on Failures #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniket866 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

CI/CD Pipeline False Positives: import-dir Exits with Code 0 on Failures #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/importDir.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ func NewImportDirCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
}

fmt.Printf("\nImport completed: %d/%d files imported successfully\n", result.SuccessCount, result.TotalFiles)
if result.FailedCount > 0 {
os.Exit(1)
}
Comment on lines 199 to +202

@Vaishnav88sk Vaishnav88sk Jul 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right behavior change for CI/CD, but please add a test that covers the partial-failure path and verifies we return a non-zero exit when FailedCount > 0.

},
}

Expand Down
Loading