Conversation
Contributor
|
Could you extend the tests for utils.R? There are other helper functions that select experiments. They all could be tested, if test are added |
Numeric altExp selection called the undefined alExps() instead of altExps(), erroring whenever altexps was specified by index. Add a regression test covering numeric altExp selection through getRDA().
0xMuluh
force-pushed
the
fix-altexps-issue3
branch
from
August 25, 2026 07:38
6a6ebf5 to
567e7c2
Compare
0xMuluh
changed the title
0xMuluh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3
Summary
This PR adds behavioral regression and characterization coverage for the experiment-selection paths used by
multiomics.The production correction for Issue #3 (
alExps()->altExps()) is already present indevel; this PR supplies the regression evidence and related selection coverage.Coverage
altExpselection throughgetRDA()Scope
getRDA()boundaryValidation