Skip to content

Export Threads dependency - #63

Merged
David-LP99 merged 1 commit into
rollingfrom
fix/export_treads_dependency
Sep 14, 2026
Merged

Export Threads dependency#63
David-LP99 merged 1 commit into
rollingfrom
fix/export_treads_dependency

Conversation

@David-LP99

@David-LP99 David-LP99 commented Sep 14, 2026

Copy link
Copy Markdown

Description

The Threads dependency added in ros2#579 and gated in #56 causes errors in consumers because they cannot resolve the Threads::Threads target in the static micro-ROS build. Because of this type of build, CMake forwards the PRIVATE Threads::Threads to the consumers, which makes it appear in rcutilsExport.cmake but undefined since Threads was not exported.

This PR solves this by exporting the target when the build needs it (RCUTILS_NO_THREAD_SUPPORT=OFF).

@David-LP99
Export Threads dependency
5dda0e6 
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@mergify

mergify Bot commented Sep 14, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

EugenioCollado
EugenioCollado approved these changes Sep 14, 2026
View reviewed changes

@EugenioCollado EugenioCollado left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@David-LP99

David-LP99 commented Sep 14, 2026

Copy link
Copy Markdown
Author

@mergify backport lyrical

@David-LP99
David-LP99 merged commit 97cb03a into rolling Sep 14, 2026
3 checks passed
@David-LP99
David-LP99 deleted the fix/export_treads_dependency branch September 14, 2026 13:46
@mergify

mergify Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

backport lyrical

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request Sep 14, 2026
Merged
David-LP99 added a commit that referenced this pull request Sep 15, 2026
@David-LP99
Export Threads dependency (#63)
8d32482 
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99 added a commit that referenced this pull request Sep 29, 2026
@David-LP99
Export Threads dependency (#63)
b93280b 
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99 added a commit that referenced this pull request Oct 6, 2026
@David-LP99 @pablogs9
@jamoralp @bjsowa @4ntn @EugenioCollado @Carlosespicur @jimmy-mcelwain
micro-ROS Rolling patch
c828b02 
* micro-ROS changes over dashing

* Added and updated security directory (#1)

* RCUTILS_NO_FILESYSTEM and RCUTILS_AVOID_DYNAMIC_ALLOCATION (#2)
  - No filesystem options; default allocators write access
  - Avoid dynamic allocation and no filesystem on error handling
  - Error handling template; new allocator approach

* Add test_security_directory test from rcl (#3)

* Zephyr fixes (#4)

* CMake refactor (#5)

* Update approach (#6)
  - Remove target_compile_definitions and refactor flags install
  - Added RCUTILS_NO_FILESYSTEM on new functions

* Updates 17092020

* Fix atomics 64bits (#9)
  - Add hashing and lock pool

* Updates 09102020

* Release micro-ROS Foxy (#8)
  - Update filesystem; adjust logger level; cleaning

* Remove build warning (#10) - avoid not used warnings

* Reduce error handling static size (#14) (#15)

* Revert "Revert "Install headers to include/${PROJECT_NAME} (ros2#351)""

* Fix atomic 64 b description (#17) (#18)

* Add fork checker for humble

* Don't link dl library when not needed (#28)

* Revert "Set hints to find the python version we actually want. (ros2#451)"

* Fix struct tm init

* Add PRId64

* Don't export dl library when not used (#33) (#34)

* Remove unnecessary folder (#42)

* Update CI (backport #43) (#46)
  - Add CI and nightly for each distro; update git version; skip tests
  - Change nightly to weekly; change master to rolling in fork checker

* Add RCUTILS_NO_PROCESS_SUPPORT option to build without fork/exec/wait (#50)

* Update CI (backport #51) (#54)

* Fix thread issues from upstream (#56)

* Fix weekly CI (backport #58) (#59)

* Export Threads dependency (#63)

Dropped during the rebase as superseded by upstream:
* Don't export dl library when not used (#33) (#34)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
Co-authored-by: Blazej Sowa <bsowa123@gmail.com>
Co-authored-by: Anton Casas <antoncasas@eprosima.com>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Co-authored-by: Jimmy McElwain <jimmy.mcelwain@motoman.com>
Signed-off-by: David Laseca <davidlaseca@eprosima.com>
David-LP99 pushed a commit that referenced this pull request Oct 6, 2026
@mergify
Export Threads dependency (backport #63) (#64)
a8d65e5 
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99 added a commit that referenced this pull request Oct 6, 2026
@David-LP99 @pablogs9
@jamoralp @bjsowa @4ntn @EugenioCollado @Carlosespicur @jimmy-mcelwain
micro-ROS Lyrical patch
3867fad 
* micro-ROS changes over dashing

* Added and updated security directory (#1)

* RCUTILS_NO_FILESYSTEM and RCUTILS_AVOID_DYNAMIC_ALLOCATION (#2)
  - No filesystem options; default allocators write access
  - Avoid dynamic allocation and no filesystem on error handling
  - Error handling template; new allocator approach

* Add test_security_directory test from rcl (#3)

* Zephyr fixes (#4)

* CMake refactor (#5)

* Update approach (#6)
  - Remove target_compile_definitions and refactor flags install
  - Added RCUTILS_NO_FILESYSTEM on new functions

* Updates 17092020

* Fix atomics 64bits (#9)
  - Add hashing and lock pool

* Updates 09102020

* Release micro-ROS Foxy (#8)
  - Update filesystem; adjust logger level; cleaning

* Remove build warning (#10) - avoid not used warnings

* Reduce error handling static size (#14) (#15)

* Revert "Revert "Install headers to include/${PROJECT_NAME} (ros2#351)""

* Fix atomic 64 b description (#17) (#18)

* Add fork checker for humble

* Don't link dl library when not needed (#28)

* Revert "Set hints to find the python version we actually want. (ros2#451)"

* Fix struct tm init

* Add PRId64

* Don't export dl library when not used (#33) (#34)

* Remove unnecessary folder (#42)

* Update CI (backport #43) (#46)
  - Add CI and nightly for each distro; update git version; skip tests
  - Change nightly to weekly; change master to rolling in fork checker

* Add RCUTILS_NO_PROCESS_SUPPORT option to build without fork/exec/wait (#50)

* Update CI (#51)

* Fix thread issues added upstream (backport #56) (#57)

* Fix weekly CI (backport #58) (#60)

* Export Threads dependency (backport #63) (#64)

Dropped during the rebase as superseded by upstream:
* Don't export dl library when not used (#33) (#34)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
Co-authored-by: Blazej Sowa <bsowa123@gmail.com>
Co-authored-by: Anton Casas <antoncasas@eprosima.com>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Co-authored-by: Jimmy McElwain <jimmy.mcelwain@motoman.com>
Signed-off-by: David Laseca <davidlaseca@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EugenioCollado EugenioCollado EugenioCollado approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@David-LP99 @EugenioCollado