Skip to content

Fix NetBar menu reopening after selecting Data Usage #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
workani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NetBar menu reopening after selecting Data Usage #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions NetBar/NetBar/MenuBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,7 @@ class MenuBarView: NSView {
}
}

override func mouseDown(with event: NSEvent) {
// Pass click to the status item's button so the menu appears
super.mouseDown(with: event)
if let menu = self.enclosingMenuItem?.menu {
menu.popUp(positioning: nil, at: NSPoint.zero, in: self)
} else {
// Forward event if wrapped in NSStatusBarButton
self.nextResponder?.mouseDown(with: event)
}
override func hitTest(_ point: NSPoint) -> NSView? {
nil
}
}