feat: support dynamic scale values - #10
Draft
e-simpson wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scale-*,scale-x-*, andscale-y-*utilities as Tailwind-style percentagesscale-[80%]scale-[1.25]Why
The parser used a fixed scale map, so valid numeric utilities such as
scale-80were silently ignored. Arbitrary percentages were also rejected even though React Native scale transforms can represent them as numeric multipliers.Numeric utility names now convert from percentages (
80to0.8) while bracketed numbers retain the existing documented raw-multiplier contract. For an 80% scale,scale-80is the canonical form; bracket syntax remains available for genuinely custom values.Impact
Callers can use any numeric scale utility without extending a hard-coded map, including axis-specific and negative variants. Existing presets and arbitrary numeric values remain backward compatible.
Validation
bun run vitest --run src/parser/transforms.test.ts(68 tests)bun run checkbun run lintbun run format:checkbun run build(via the Bun dependency refresh prepare script)