Extract common logics to helper functions#55
Open
GardevoirX wants to merge 5 commits into
Open
Conversation
Member
No, the pairs code already properly handle this in LAMMPS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have
compute metatomic,fix metatomic, andpair metatomic. And they share a lot of common parts. This PR aims at extracting them and put them into files likemetatomic_systemsandmetatomic_typesto ensure that in the future development these shared code won't be out of syncOne thing I am not sure is that this part exists in both
computeandfix, but not inpairidk if this should also be in
pair