You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(core): capture how docusaurus serve handles client redirect files of .html paths - #12919
Capture a docusaurus serve bug before fixing it in the next PR of this stack.
For a redirect from a .html path, like from: '/old-page.html', @docusaurus/plugin-client-redirects writes old-page.html/index.html, or old-page.html.html with trailingSlash: false. docusaurus serve never serves these files at /old-page.html: it redirects to /old-page, which is a 404.
Redirects from .html URLs are common when migrating a site from another tool, and the plugin's fromExtensions: ['html'] option creates them too.
This PR renames the existing fixture to redirect-folder.html/index.html, adds redirect-file.html.html for the trailingSlash: false file, requests both with and without a trailing slash in the snapshots, and adds 2 TODO fix tests.
End-to-end repro: a real site built with plugin-client-redirects
/old-page.html requested on the build output, compared with python3 -m http.server as a plain static server:
No actionable comments were generated in the recent review.
Walkthrough
The serve request tests replace the legacy HTML case with client-redirect file and folder paths. They check redirect and 404 results across trailing-slash settings and base URLs.
Changes: Client-redirect HTML request tests
Layer / File(s)
Summary
Redirect fixtures and request expectations packages/docusaurus/src/commands/serve/__tests__/__fixtures__/build/*, packages/docusaurus/src/commands/serve/__tests__/requestHandler.test.ts
The fixtures and tests cover client-redirect file and folder paths with and without trailing slashes. Expectations cover all tested trailingSlash settings and base URL configurations, including redirect chains that return 404. The legacy HTML fixture and its expectations are removed.
meta/docusaurus#12904: This PR adds client-redirect folder and file cases to the existing .html request tests.
meta/docusaurus#12858: This PR extends the request-handler fixture and snapshot suite introduced by this PR.
meta/docusaurus#12920: This PR addresses the client-redirect file 404 cases recorded in these tests.
Merge Risk: Minimal · up to 05fa6
This test-only change documents existing client-redirect behavior across URL and trailing-slash configurations. No actionable merge-blocking risk is identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title accurately describes the tests for how docusaurus serve handles client redirect files for .html paths.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedSigned Facebook CLApr: maintenanceThis PR does not produce any behavior differences to end users when upgrading.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Capture a
docusaurus servebug before fixing it in the next PR of this stack.For a redirect from a
.htmlpath, likefrom: '/old-page.html',@docusaurus/plugin-client-redirectswritesold-page.html/index.html, orold-page.html.htmlwithtrailingSlash: false.docusaurus servenever serves these files at/old-page.html: it redirects to/old-page, which is a 404.Redirects from
.htmlURLs are common when migrating a site from another tool, and the plugin'sfromExtensions: ['html']option creates them too.This PR renames the existing fixture to
redirect-folder.html/index.html, addsredirect-file.html.htmlfor thetrailingSlash: falsefile, requests both with and without a trailing slash in the snapshots, and adds 2TODO fixtests.End-to-end repro: a real site built with plugin-client-redirects
/old-page.htmlrequested on the build output, compared withpython3 -m http.serveras a plain static server:Python's server has no clean URLs, so it can't serve
old-page.html.htmlat/old-page.html.Test Plan
pnpm test packages/docusaurus/src/commands/serveTest links
Deploy preview: https://deploy-preview-12919--docusaurus-2.netlify.app/
Related issues/PRs
Follows meta/docusaurus#12916
🤖 Generated with Claude Code
Summary by CodeRabbit
.htmlnames, including paths with and without trailing slashes..htmlpath.