Repository navigation
fix(core): docusaurus serve no longer crashes on file names with Latin-1 characters (AI-assisted) - #12895
Merged
Conversation
…n-1 characters (AI-assisted) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
docusaurus servecrashes withERR_INVALID_CHARwhen serving a file whose name has Latin-1 characters, likecafé.html. serve-handler sends aContent-Disposition: inline; filename="café.html"header, and Node.js rejects this raw non-ASCII value inwriteHead(). The error is an unhandled rejection that stops the server process. This is vercel/serve-handler#205, still open, and 6.1.7 is the latest version.The fix uses serve-handler's
headersoption to replace the header withContent-Disposition: inline, without the file name.inlineis already the default for browsers, and they take the file name from the URL when saving the file.Fix #10665
Test Plan
pnpm test packages/docusaurus/src/commands/serve: the/caférows servecafé.htmlon both platforms, and the edge case test is flipped to "serves file names with Latin-1 characters".Test links
Deploy preview: https://deploy-preview-12895--docusaurus-2.netlify.app/
Related issues/PRs
(AI-assisted)
🤖 Generated with Claude Code