You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(core): merge the Windows docusaurus serve snapshots (AI-assisted) - #12894
The docusaurus serve tests had Windows-only variants of 2 trailingSlash: true snapshots, because Windows served file URLs with a trailing slash where other platforms answered 404. #12877 removed these trailing slash redirects, and the variants have been identical since: this PR merges them, as 12877 announced.
Test Plan
pnpm test packages/docusaurus/src/commands/serve: no snapshot row changes. The Windows CI job runs the merged tests.
No actionable comments were generated in the recent review.
Walkthrough
The /base/ serving tests for trailingSlash: true now run on all platforms. Duplicate Windows-only coverage was removed. Hand-typed URL tests retain the same expected redirects and 400 Bad Request responses.
Changes: Cross-platform /base/ test coverage
Layer / File(s)
Summary
Consolidate platform-specific test coverage packages/docusaurus/src/commands/serve/__tests__/requestHandler.test.ts
The serving test and hand-typed URL test for trailingSlash: true now run on all platforms. The duplicate Windows-only test was removed. Expected redirects and 400 Bad Request responses are unchanged.
meta/docusaurus#12858: Adds /base/ request-handler snapshots used by the consolidated tests.
meta/docusaurus#12881: Adds platform-specific snapshots for hand-typed URLs with trailingSlash: true, which this change consolidates.
meta/docusaurus#12865: Introduces createServeRequestHandler, which the consolidated tests use through the test utility.
Merge Risk: Minimal · up to f8875
The test consolidation presents no identified merge-blocking issue and is ready to merge after normal checks pass.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the merge of the Windows docusaurus serve test snapshots.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedSigned Facebook CLApr: maintenanceThis PR does not produce any behavior differences to end users when upgrading.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
docusaurus servetests had Windows-only variants of 2trailingSlash: truesnapshots, because Windows served file URLs with a trailing slash where other platforms answered 404. #12877 removed these trailing slash redirects, and the variants have been identical since: this PR merges them, as 12877 announced.Test Plan
pnpm test packages/docusaurus/src/commands/serve: no snapshot row changes. The Windows CI job runs the merged tests.Test links
Deploy preview: https://deploy-preview-12894--docusaurus-2.netlify.app/
Related issues/PRs
docusaurus serveno longer adds a trailing slash to some assets under a baseUrl (AI-assisted) #12877(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit