Repository navigation
Conversation
The default NRF_TWIM0 alias is TWIM20, which shares SERIAL20 with UARTE20. These variants define Serial2, so Uart.cpp and Wire both define SERIAL20_IRQHandler and any sketch using Wire fails to link. Use TWIM22, as the nRF54L15 boards do; the nRF54L05 and L10 MDK headers define NRF_TWIM22 and SERIAL22_IRQn.
Blink only pulls in the core, so CI never compiled anything under libraries/. tests/libraries includes and uses each bundled library, and takes its boards, platform and framework symlink from tests/blink through extra_configs, so the two can't drift apart. CI builds it after blink for every board. Left out: BLEAdafruitService needs Adafruit libraries from the registry, and PDM, Servo and BLEHomekit don't build on the nRF54L.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
CI only builds
tests/blink, which pulls in the core and nothing underlibraries/, so a change to Bluefruit54Lib, nRF54Crypto, LittleFS, Wire and the rest passes CI without being compiled. This addstests/libraries, a sketch that includes and calls each bundled library, and CI builds it for every board after blink. It takes its boards, platform and framework symlink fromtests/blinkthroughextra_configs, so the two can't drift apart.The new test found a bug on the way. On the nRF54L10-DK and nRF54L05-DK,
Wireuses the defaultNRF_TWIM0alias, TWIM20, which shares SERIAL20 withSerial2's UARTE20. Both defineSERIAL20_IRQHandler, so any sketch that usesWireon those boards fails to link. The first commit routesWireto TWIM22, as the nRF54L15 variants already do; the L05 and L10 MDK headers defineNRF_TWIM22andSERIAL22_IRQn.Left out of the test:
BLEAdafruitServiceneeds Adafruit libraries from the registry (NeoPixel, Unified Sensor, AHRS, Sensor Calibration).PDMandServostop with#erroron anything but nRF52, andBLEHomekitdoesn't compile against Bluefruit54Lib (AdvertisableandBLEAdvertisingDataaren't there, andcrypto.chas C++ in a.cfile). None of the three has been ported to the nRF54L. I can remove them or port them in a separate PR, whichever you prefer.Testing
Both steps pass for the five boards on my fork's CI: https://github.com/cvaldess/nRF54_Arduino/actions/runs/43725779089. The log shows Bluefruit54Lib, nRF54Crypto, Wire and the rest being compiled. Locally, with platform v0.5.0, the nRF54L10-DK ELF has
Wire's handler on SERIAL22 andSerial2's on SERIAL20.This is compile-only: nothing here has run on hardware, and I don't have an L10 or L05 DK.
Summary by CodeRabbit