Skip to content

Fix CC310 Mutex Lock #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ripplebiz merged 1 commit into from
Nov 15, 2026
+11 −0
Merged

Fix CC310 Mutex Lock #3849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Identity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
#ifdef USE_CC310_HW_CRYPTO
#include <Adafruit_nRFCrypto.h>
#include "nrf_cc310/include/crys_ec_edw_api.h"
#include "nrf_cc310/include/ssi_pal_mutex.h"
extern "C" {
extern SaSi_PalMutex sasiAsymCryptoMutex;
}
#endif

namespace mesh {
Expand All @@ -30,6 +34,13 @@ bool Identity::verify(const uint8_t* sig, const uint8_t* message, int msg_len) c
CRYSError_t rc = CRYS_ECEDW_Verify((uint8_t*)sig, CRYS_ECEDW_SIGNATURE_BYTES,
(uint8_t*)pub_key, CRYS_ECEDW_MOD_SIZE_IN_BYTES,
(uint8_t*)message, (size_t)msg_len, &cc310_tmp);

// workaround for CC310 v0.9.13 where mutex can still be locked after a failed verification
if (rc != CRYS_OK && sasiAsymCryptoMutex != 0) {
MESH_DEBUG_PRINTLN("CRYS_ECEDW_Verify mutex still locked after error result, unlocking");
SaSi_PalMutexUnlock(&sasiAsymCryptoMutex);
}

return rc == CRYS_OK;
#elif 0
// NOTE: memory corruption bug was found in this function!!
Expand Down
Loading