Revert nRF52 toolchain to gcc 9.3.1 to avoid build errors - #3369
Open
YoshiWalsh wants to merge 1 commit into
Open
Revert nRF52 toolchain to gcc 9.3.1 to avoid build errors#3369YoshiWalsh wants to merge 1 commit into
YoshiWalsh wants to merge 1 commit into
Conversation
Newer versions of gcc cause build failures for variants that include use of MicroNMEA.
Author
|
CC: @liamcottle |
Member
Hey there! I've just checked, and Can you try cleaning your dev environment (remove I've tested latest dev commit in our GitHub Actions environment and my MacBook and the Your compilation error is complaining about GitHub Actions Build: https://github.com/liamcottle/MeshCore/actions/runs/34067454922/job/101578665668 MacBook Pro Build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes build errors introduced by #3246. The
stevemarple/MicroNMEAdependency does not currently support newer versions of gcc, and neither does our MicroNMEALocationProvider class.I have tested, and of the gcc versions made available by toolchain-gccarmnoneeabi, 9.3.1 is the newest that allows us to build successfully. This is still an upgrade over the version we were previously using, 7.2.1. 10.3.1 and newer results in the following error: