Skip to content

Fix flaky UseReaderWithoutDisposing test on high-latency servers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmishchenko-ua wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky UseReaderWithoutDisposing test on high-latency servers #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/SideBySide/QueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,13 @@ public void UseReaderWithoutDisposing()
var csb = AppConfig.CreateConnectionStringBuilder();
csb.MaximumPoolSize = 8;

// This test intentionally starts more threads than MaximumPoolSize and leaves readers undisposed,
// so returning each connection to the pool requires a session reset. Against a high-latency managed
// server those resets are slow enough that excess threads can exceed the default 15s pool-wait
// timeout and fail with "Connect Timeout expired. All pooled connections are in use." Use a generous
// timeout so the test exercises pool reuse without being sensitive to connection latency.
csb.ConnectionTimeout = 60;

using (var connection = new SingleStoreConnection(csb.ConnectionString))
{
connection.Execute(@"drop table if exists dispose_reader;
Expand Down