Repository navigation
chore(ci): do not persist the checkout token in uni.yml - #36
Merged
Merged
Conversation
github-actions
Bot
added
the
needs-human-review
Contributor
|
This pull request touches 1 path(s) that Mergify never merges on its own. The owner merges it by hand, or closes it.
Pattern: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uni.ymlhas no top-levelpermissions, and its fouractions/checkoutsteps keep the job token in.git/configby default. None of these jobs pushes or fetches afterwards, andadapters/githubuses neither git nor a token, sopersist-credentials: falseremoves a token that build scripts and tests could otherwise read.Canary: negative, for the Mergify policy adopted in #34. It touches
.github/, so Mergify must leave it open with green CI. It is a real hardening: merge it by hand whenever you like.Refs memolabs-dev/memo-bridge#149