Skip to content

docs(agents): point the review criteria at the synced REVIEW.md - #159

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/review-md-pointer
Oct 30, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/review-md-pointer

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/standards#726

Summary

REVIEW.md now exists at this repository's root through the review-instructions sync component. The AGENTS.md Code Review Rules pointer still links the canonical URL, so the code-review-rules audit reports it as missing the local link.

Fix

Replace the URL-form pointer with a link to the local REVIEW.md, worded as in the other enrolled repositories. No CI root-coverage or path-classification step in this repository classifies top-level files, so no workflow change is needed.

Verification

  • git diff shows one changed line in AGENTS.md.
  • The audit checker's expected form is the one in the standards#726 plan.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX

@kyle-sexton
kyle-sexton marked this pull request as ready for review October 30, 2026 21:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T21:45:29.141266Z 7d951f5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 7d951f5483fa2d32795e6cd50a8496a3e7a76b1b: 0 finding(s), 0 as inline comments.

No findings. The PR changes one line in AGENTS.md. It replaces the absolute URL pointer to REVIEW.md in melodic-software/standards with a repository-relative link to REVIEW.md. I confirmed that REVIEW.md exists at the repository root, so the link resolves. It also matches the repository rule that paths stay relative. The PR touches no plugin manifests and no .claude/rules path rule, so those checks don't apply. The PR context names no closing issue (Refs: melodic-software/standards#726 only), so there are no acceptance criteria to check. The PR body's verification claims are author-claimed and unverified, apart from the REVIEW.md existence check above.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 7d951f5483fa2d32795e6cd50a8496a3e7a76b1b: 0 finding(s), 0 as inline comments.

Security review: PR #159 @ 7d951f5

critical-findings: 0

The PR changes one line in AGENTS.md. The line used to link the org-wide REVIEW.md by its canonical URL in melodic-software/standards. It now links the local REVIEW.md, which I confirmed exists at the repository root.

  • Instruction-surface lens: The edit changes only where the pointer points. It keeps the "Org-wide criteria" bullet and removes no rule from the Code Review Rules list. Nothing is deleted, narrowed or softened, and no rule loses its enforcement. I did not consult the instruction exception register file.
  • Trust controls and trusted paths: No trusted-actor list, token scope, kill switch, merge hold, CODEOWNERS, .gitmodules or .github/actions/ file is touched.
  • Manifests: No plugin.json or marketplace.json change, so there are no manifest <field> lines.
  • PR text: The body holds no embedded instructions aimed at the review.
  • Local REVIEW.md: The PR does not modify it. Its content arrives through the org sync component, outside this diff, so I did not review it here.

No security issues found.

@kyle-sexton
kyle-sexton merged commit cca7c38 into main Oct 30, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the docs/review-md-pointer branch October 30, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant