Skip to content

fix(source-control): skip the sandbox's /dev/null dotfile masks in feedback-thread record #9551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 24, 2026
Merged

fix(source-control): skip the sandbox's /dev/null dotfile masks in feedback-thread record #9551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/source-control/fix-feedback-thread-sandbox-devnull-5dcba90c.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Fixed

- `feedback-thread.sh record` no longer refuses a VALID reply because the lane's sandbox masks a dotfile in the checkout (such as `.bash_profile`) with `/dev/null`. It skips a character device that is not a symlink, as `check-affected.sh` does. An untracked symlink to `/dev/null` is still refused. This was why address-feedback stopped with `feedback-invalid` or `feedback-incomplete` on lane PRs whose findings it had fixed.
2 changes: 2 additions & 0 deletions plugins/source-control/skills/pull-request/scripts/feedback-thread.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ cmd_record() {
mapfile -d '' -t untracked < <(git_tree ls-files --others --exclude-standard -z)
wait "$!" || die 1 "cannot read the working tree's untracked files"
for path in "${untracked[@]}"; do
# The lane's sandbox masks a dotfile with /dev/null, a device git will not add.
[[ -L $workspace/$path || ! -c $workspace/$path ]] || continue
is_stub "$path" || paths+=("$path")
done
((${#paths[@]} < 300)) || die 1 "the working tree changes too many files to check"
Expand Down
19 changes: 19 additions & 0 deletions plugins/source-control/skills/pull-request/scripts/feedback-thread.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,25 @@ echo 'guarded' >"$STUB/ws/src/a.js"
mkdir -p "$STUB/ws/src/nested" && : >"$STUB/ws/src/nested/package.json"
run record PRRT_a "$STUB/scratch/d.json" >/dev/null 2>&1
assert_exit "an empty stub name below the top of the checkout refuses the VALID record" 1 "$?"
# The lane's sandbox masks a dotfile in the checkout with /dev/null, a device git
# will not add: it is no fix, while a symlink to /dev/null still is one.
if bwrap --bind / / --dev /dev true 2>/dev/null; then
setup
echo 'guarded' >"$STUB/ws/src/a.js"
: >"$STUB/ws/.bash_profile"
disposition '{"disposition":"VALID","evidence":["src/a.js:3"],"fix_sha":"","note":"fixed"}'
PATH="$TEST_TMPDIR/bin:$PATH" FEEDBACK_THREADS="$STUB/threads.json" FEEDBACK_LOG="$STUB/replies.jsonl" \
FEEDBACK_SCRATCH="$STUB/scratch" FEEDBACK_WORKSPACE="$STUB/ws" \
bwrap --bind / / --dev /dev --ro-bind /dev/null "$STUB/ws/.bash_profile" \
bash "$SCRIPT" record PRRT_a "$STUB/scratch/d.json" >/dev/null 2>&1
assert_exit "a sandbox /dev/null mask over a dotfile does not refuse the VALID record" 0 "$?"
fi
setup
echo 'guarded' >"$STUB/ws/src/a.js"
ln -s /dev/null "$STUB/ws/.bash_profile"
disposition '{"disposition":"VALID","evidence":["src/a.js:3"],"fix_sha":"","note":"fixed"}'
run record PRRT_a "$STUB/scratch/d.json" >/dev/null 2>&1
assert_exit "an untracked symlink to /dev/null refuses the VALID record" 1 "$?"

setup
disposition '{"disposition":"VALID","evidence":["src/a.js:3"],"note":"fix_sha left out"}'
Expand Down
Loading