Skip to content

test(pr-pipeline): pin that fix-ci pushes an exec-bit and fixture fix #9407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 3 commits into from
Oct 23, 2026
Merged

test(pr-pipeline): pin that fix-ci pushes an exec-bit and fixture fix #9407

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e978b50
test(pr-pipeline): pin that fix-ci pushes an exec-bit and fixture fix…
kyle-sexton Oct 23, 2026
ca4053b
Merge remote-tracking branch 'origin/main' into fix/9320-ci-fix-exec-…
kyle-sexton Oct 23, 2026
1fd15cd
test(pr-pipeline): drop the incident aside from the exec-bit test com…
kyle-sexton Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/scripts/apply-patch/apply-patch.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,28 @@ test("a new executable bit the patch sets pushes with the mode it set", async (t
assert.equal(git(fix.repo, ["ls-tree", createCommit.tree, "--", "README.md"]).split(" ")[0], "100755");
});

// A fix that makes two 100644 scripts executable and edits a test fixture,
// with no path under .github/.
test("under the ci-context row a fix that sets script exec bits and edits a fixture pushes, escalating nothing", async (t) => {
const fix = repoWithPatch(
t,
(repo) => {
chmodSync(join(repo, "scripts/x.sh"), 0o755);
chmodSync(join(repo, "scripts/y.sh"), 0o755);
writeFileSync(join(repo, "notes.md"), "notes\nget-field-options\n");
},
{ head: (repo) => writeFileSync(join(repo, "scripts/y.sh"), "#!/bin/sh\n") },
);
const api = fakeApi(fix.repo, fix.head);
const lines = [];
assert.deepEqual(await pushWith(fix, api, { row: row("ci-context"), log: (line) => lines.push(line) }), { outcome: "pushed", commit: "c".repeat(40), branch: "feat/x" });
assert.deepEqual(lines, ["pushed " + "c".repeat(40) + " (3 path(s)) onto feat/x"]);
const { createCommit } = api.calls.find((call) => call.createCommit);
for (const path of ["scripts/x.sh", "scripts/y.sh"]) {
assert.equal(git(fix.repo, ["ls-tree", createCommit.tree, "--", path]).split(" ")[0], "100755", path);
}
});

test("refuses a rename from an allowed path into .github/workflows/", async (t) => {
const fix = repoWithPatch(
t,
Expand Down
Loading