Skip to content

refactor\(source-control\)!: remove resolve-conflicts in favour of the pull-request conflict mode - part 3 of 3 #13199

Closed

Description

@melodic-automation-lanes

Part 3 of 3 of #13138, split at intake (owner Q93). The done-when below is copied from #13138 as written.

Done when

  • plugins/source-control/README.md, docs/skill-cheat-sheet.md:229, plugins/work-items/skills/ship/actions/run.md:81 and its eval, and docs/upstream/mattpocock-skills.md:55,58 (which still says "keep ours pending an eval") are updated to the removal.
  • rg -n 'source-control:resolve-conflicts' plugins docs .github --glob '!**/CHANGELOG.md' --glob '!.changes/**' finds nothing, and node --test '.github/scripts/pr-unblock/*.test.mjs' exits 0 in the PR's CI.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 4, 2026
  2. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: #13197, #13198

    I understood this as part 3 of 3 of #13138, which removes source-control:resolve-conflicts. This part updates the remaining docs, the ship action and its eval, and the upstream note. It is done when the rg search finds no references and the pr-unblock tests pass in CI. The scope is clear. The part 1 and part 2 issues (#13197, #13198) are siblings, not duplicates. I listed them as blockers because the final grep check can only pass once the removal itself has landed.

    Automated triage, applied by the lanes App.

  3. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 4, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Nov 4, 2026
  5. melodic-automation-lanes commented on Nov 4, 2026

    @melodic-automation-lanes
    ContributorAuthor

    Not admitted to the issue lane: merged pull request #13256 names it with Refs: after its newest decision or refinement comment, so its work may already be done: close the issue if it is, or post a comment whose first line is **Decision recorded.** saying what is left, which sends it back through intake. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  6. added
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    and removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    on Nov 4, 2026
  7. kyle-sexton commented on Nov 4, 2026

    @kyle-sexton
    Member

    Delivered: closing as completed.
    Agent choice, not an owner answer.

    • Item 1 (the README, docs/skill-cheat-sheet.md, plugins/work-items/skills/ship/actions/run.md and its eval, and docs/upstream/mattpocock-skills.md updated to the removal): delivered by refactor(source-control)!: remove resolve-conflicts in favour of the pull-request conflict mode #13256 (merge commit 9b3f10f); its pr-verify note records this item delivered in full.
    • Item 2, run at that merge commit in a checkout of 9b3f10f:
      • rg -n 'source-control:resolve-conflicts' plugins docs .github --glob '!**/CHANGELOG.md' --glob '!.changes/**': no matches (exit 1).
      • node --test '.github/scripts/pr-unblock/*.test.mjs': tests 1326, pass 1326, fail 0.

    The PR's own CI never selected the pr-unblock suites (#13256 touches no pr-unblock file), so item 2 is settled by this run at the merge commit; #13266 tracks that gap in pr-verify.

  8. kyle-sexton commented on Nov 4, 2026

    @kyle-sexton
    Member

    Closing on the delivery record above (issuecomment-6634167843): both items met at merge commit 9b3f10f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    Work status

    confirmed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions