Repository navigation
Closed
Copy link
Labels
priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.Refactors, migrations, contract changes; cross-cutting and hard to reverse.
Description
Part of #7576 (PR 1 of 3).
Problem
Review venue is detected automatically per lane (plugins/source-control/skills/pull-request/reference/review-venue.md, scripts/review-venue.sh), but a repository cannot set it. #7576's Key interfaces and the owner's interview answers name one setting: "one review venue per PR via review_venue (auto, local, ci, both; default auto)" (Q500), with CI lanes as the default venue (Q605: "KEEP, with CI lanes as the venue.").
Done when
-
docs/conventions/source-control.yaml,plugins/source-control/schemas/source-control.schema.json(which setsadditionalProperties: false, line 7) and the source-controlplugin.jsonuserConfigdeclarereview_venuewith valuesauto,local,ci,bothand defaultauto, repo scope, resolved likepr_open_state(repository value overuserConfig). -
plugins/source-control/skills/pull-request/reference/review-venue.mdreads the setting first:autokeeps today's per-lane read ofreview-venue.sh;localruns every local review step and skips the script;ciskips the local review steps whatever the script prints;bothruns the local steps and still counts the CI lanes. Each value has its report line. - A test beside
scripts/review-venue.test.sh(or the setting reader's test) covers each of the four values and an unknown value, which falls back toautowith a notice. - After the first whole review on a PR, the CI review lanes post only blocking findings (Q500: "blocking-only after the first review"). Main has this rule only past the round cap (
plugins/review/skills/code-review/SKILL.md:249andplugins/review/skills/security-review/SKILL.md:379, "When the prior-findings file sayspast the cap: yes"); move that trigger to "after the first whole review" in both skills and in whatever writes the marker (plugins/review/lib/prior-findings.mjs), rather than adding a second rule. - Changelog fragments for source-control and review.
Filed by Issue Triage from the #7576 spec (agent choice, verified against main). This was generated by AI.
Metadata
Metadata
Assignees
Labels
priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.Refactors, migrations, contract changes; cross-cutting and hard to reverse.
Type
Fields
No fields configured for Task.
Activity
github-actions commentedon Nov 4, 2026
Proposed work class: work-class: structural
Basis: automated intake triage; the lanes App applied this class.
Size: Medium
Complexity: Medium
Uncertainty: Known
Flags: none
Blocked by: none
Understood: add a repo-scoped
review_venuesetting (auto,local,ci,both; defaultauto) to the source-control conventions file, schema and plugin userConfig, and makereview-venue.mdread it first. Add a test for the four values plus an unknown value that falls back toauto. Move the blocking-only trigger in both review skills andprior-findings.mjsfrom "past the cap" to "after the first whole review". Add changelog fragments for source-control and review.The done-when items are specific, so nothing is missing. I found no open duplicate. It is part of #7576.
Automated triage, applied by the lanes App.
github-actions commentedon Nov 4, 2026
github-actions commentedon Nov 4, 2026