Repository navigation
chore(git-hooks): run the guardrails git hooks from the claude-code-plugins lefthook remote - #870
Conversation
… jobs Commit the guardrails plugin's commit-msg-convention, pre-commit-content and reference-verify entries as shared lefthook jobs, so every clone gets them from `lefthook install`, and record the subject_pattern they enforce in .claude/source-control.md. The copies under .githooks/guardrails/ are plugin-owned (guardrails 0.55.4). CI's ShellCheck job and machine-specific path scan skip them: ShellCheck flags 13 findings in the copies, and the path scan self-matches the pattern sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73f50948bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…lugins lefthook remote Replace the vendored .githooks/guardrails copies and their lint and machine-path exclusions with one lefthook remotes entry pointing at claude-code-plugins main (plugins/guardrails/git-hooks/lefthook-remote.yml). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 2m 52s —— View job Security review complete
Scope: the only changed file is 1 finding (inline comment on Verified by an independent adversarial pass before posting (confirmed lefthook's No Actions-workflow files, secrets handling, injection surfaces, or access-control code were touched by this PR, so no findings beyond the one above. critical-findings: 0 claude-lane-summary: lane=claude-security-review sha=c5fd691999f07494e3bcfce48315ece7a9a15f17 run=40060694646 |
|
Claude finished @kyle-sexton's task in 1m 43s —— View job Code review — PR #870
Scope. The diff is a single 6-line addition, Findings: none. The change is declarative CI/dev-tooling config with no logic to break:
Other checks.
No holds ( claude-lane-summary: lane=claude-review sha=c5fd691999f07494e3bcfce48315ece7a9a15f17 run=40060694646 |
|
claude-review has reviewed this pull request through c5fd691; a later push is reviewed from there. |
|
claude-security-review has reviewed this pull request through c5fd691; a later push is reviewed from there. |
No related issue: rolls out the guardrails lefthook remote (claude-code-plugins#9504)
Summary
Runs the guardrails plugin's three git hooks in this repository from one lefthook
remotes:entry, so every clone gets the same hooks from committed config and picks up upstream changes within 24 h:commit-msg-convention(commit-msg): the subject against the repository's commit convention (docs/conventions/source-control/commit-convention.yml).pre-commit-content(pre-commit): secrets and machine-specific paths on added lines.reference-verify(pre-push): CLI flags,/plugin:skillreferences and deleted paths on pushed lines.Fix
lefthook.yml(new; the repository had no hook manager): only aremotes:entry forhttps://github.com/melodic-software/claude-code-plugins,ref: main,refetch_frequency: 24h, configplugins/guardrails/git-hooks/lefthook-remote.yml..githooks/guardrails/copies, the three localguardrails-*jobs, theshellcheckexclude:and themachine-specific-paths-excludeaddition in.github/workflows/pr-require-checks.yml, and the## subject_patternsection in.claude/source-control.md(main now carriescommit-convention.yml). The ShellCheck exclude issue ci-workflows#871 is moot.Verification
install.mjs verify --repo <worktree>(rc 0):install.mjs plan --scope remoteafterwards: no decisions left. This PR's commit and push ran the remote jobs (guardrails-remote-reference-verifypassed on push).Observation runs from the earlier revision still hold, since the remote runs the same hook scripts:
reference-verifyorigin/main~200..origin/main(86 changed.md/.sh/.ps1files), 28 s.github/actions/pr-require-checks/aggregate-results/run.test.sh(138,358 bytes) exceeds the 128 KiB per-argument limit, sojqfails withArgument list too longand the file is skipped without a finding. Item 4 of claude-code-plugins#9426pre-commit-contentupdate-ref HEAD c~1 && read-tree c; 424 staged files in all), 20 s total/home/<name>/path) blocks with rc 1commit-msg-conventionsubject_patterntested against the last 500 subjects on mainRelated
🤖 Generated with Claude Code