[MCC-1535269] Python SDK - Remove dataset_batch_number from publish and dry_publish results - #57
Merged
Conversation
…nd dry_publish results
glondhe-mdsol
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug
Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
Remove
dataset_batch_numberfromResultMetadataand the_PublishEnvelopeResultflat accessor so the field is absent from bothrepr()andasdict()output, covering the QA validation path (json.dumps(asdict(result))).dataset_batch_numberfield fromResultMetadatadataclass.dataset_batch_numberproperty shim from_PublishEnvelopeResult._envelope_to_domain;transport/models.pyis untouched (server still sends it, transport still parses it).repr-based test assertions withasdict-based ones to match the actual QA evidence path.Deployment Notes
result.dataset_batch_numberandresult.metadata.dataset_batch_numbernow raiseAttributeError. Any callers reading the field directly will need to be updated.