Skip to content

[MCC-1535269] Python SDK - Remove dataset_batch_number from publish and dry_publish results - #57

Merged
dsilaghi-mdsol merged 1 commit into
mainfrom
fix/MCC-1535269-remove-dataset-batch-number
Aug 5, 2026
Merged

[MCC-1535269] Python SDK - Remove dataset_batch_number from publish and dry_publish results#57
dsilaghi-mdsol merged 1 commit into
mainfrom
fix/MCC-1535269-remove-dataset-batch-number

Conversation

@dsilaghi-mdsol

Copy link
Copy Markdown
Contributor

bug

  • Python SDK - Remove dataset_batch_number from publish and dry_publish results
  • MCC-1535269

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

Remove dataset_batch_number from ResultMetadata and the _PublishEnvelopeResult flat accessor so the field is absent from both repr() and asdict() output, covering the QA validation path (json.dumps(asdict(result))).

  • Drop dataset_batch_number field from ResultMetadata dataclass.
  • Drop the flat dataset_batch_number property shim from _PublishEnvelopeResult.
  • Stop mapping the field in _envelope_to_domain; transport/models.py is untouched (server still sends it, transport still parses it).
  • Replace repr-based test assertions with asdict-based ones to match the actual QA evidence path.

Deployment Notes

result.dataset_batch_number and result.metadata.dataset_batch_number now raise AttributeError. Any callers reading the field directly will need to be updated.

@dsilaghi-mdsol dsilaghi-mdsol self-assigned this Aug 5, 2026
@dsilaghi-mdsol dsilaghi-mdsol added bug Something isn't working python Pull requests that update python code and removed bug Something isn't working labels Aug 5, 2026
@dsilaghi-mdsol
dsilaghi-mdsol merged commit 6723e2a into main Aug 5, 2026
3 of 4 checks passed
@dsilaghi-mdsol
dsilaghi-mdsol deleted the fix/MCC-1535269-remove-dataset-batch-number branch August 5, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants