refactor(pkgs): nlohmann.json + compat.eigen generated_files -> Lua long brackets (P3)#66
Merged
Merged
Conversation
…ong brackets (P3) Mechanical migration of the escaped single-line generated_files strings to [==[ ... ]==] long-bracket form (mcpp >= 0.0.85; the P1 floor gates this). Reviewability is the point: module wrapper sources become readable multi-line code instead of multi-KB one-liners. Verified: parity oracle — `mcpp xpkg parse --json` generated_contents byte-identical before/after for both; lua5.4 loadfile green (xim side still executes these); nlohmann.json and eigen member tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3 of the 0.0.85 adoption train (P1 = #65, merged). Mechanical migration of the escaped single-line generated_files strings to
[==[ … ]==]long-bracket form — module wrapper sources become readable multi-line code instead of multi-KB one-liners.Verified: parity oracle —
mcpp xpkg parse --jsongenerated_contents byte-identical before/after for both descriptors; lua5.4 loadfile green (xim side); nlohmann.json and eigen workspace member tests pass locally with 0.0.85. The new strict lint (P1) re-verifies both grammars in CI.