Skip to content

feat(ci): add basic CI & doc deployments - #45

Merged
jumpy-cat merged 4 commits into
devfrom
gh-actions
Aug 2, 2026
Merged

feat(ci): add basic CI & doc deployments#45
jumpy-cat merged 4 commits into
devfrom
gh-actions

Conversation

@jumpy-cat

@jumpy-cat jumpy-cat commented Jul 19, 2026

Copy link
Copy Markdown
Member

Description

Added github-actions workflow that runs type-checking, tests, and builds+uploads the typedoc docs. Other changes made include adjusting tsconfig.json to fix some issues, removing the docs/ directory & adding it to .gitignore, and making the timestamp checks in reminder.test.ts less strict so the delayed output of the mock bustime servers pass.

Type of Change

  • New feature (feat)
  • Bug fix (fix)
  • Refactor / code improvement
  • Dependency / build update
  • Documentation
  • Other (explain)

Related Issues

Progress towards #30, soft prereq for #40 and mbusdev/bluebus-flutter#98

Changes Made

  • Flutter: n/a
  • Backend (TypeScript):
    • adjusted module resolution from Node to bundler: Node is deprecated and changing to nodenext would require refactoring some imports
    • modified reminder test suite & main server to have the option of using mock bustime servers and loosened the timestamp checks
      • this weakens the test suite a bit, but the main potential problem (bustime servers responding with human readable time when we ask for unix ts) is still being caught
      • the test still might be a bit flaky due to firebase auth not being setup and the reminder test suite having the side-effect of attempting to send actual notifications, waiting to see if this is an actual problem
    • reminders: exported more things to fix issues with docs
    • removed the legacy directory & code
  • Firebase / Shared: n/a

Testing Done

Backend logic is unchanged, confirmed typedoc ftp uploads behave properly.

Checklist

  • Commit messages follow Conventional Commits
  • PR title follows [type](scope): short description
  • PR target branch is not main and is our current working update branch (e.g. maizebus2.1)
  • No print() / debugPrint() / console.log() left in production code
  • Secrets / keys not committed

@jumpy-cat jumpy-cat changed the title chore: add basic CI feat: add basic CI & doc deployments Jul 19, 2026
@jumpy-cat
jumpy-cat marked this pull request as ready for review July 20, 2026 03:38
@jumpy-cat
jumpy-cat force-pushed the gh-actions branch 2 times, most recently from 4058009 to f3b3e15 Compare July 20, 2026 17:18
@jumpy-cat
jumpy-cat requested a review from dotSol0 July 25, 2026 15:23

@dotSol0 dotSol0 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any explicit errors. Your changes in the code accurately reflect the changes you are doing. I approve this for merging

@jumpy-cat
jumpy-cat changed the base branch from dev to main August 1, 2026 22:25
@jumpy-cat
jumpy-cat changed the base branch from main to dev August 1, 2026 22:37
@jumpy-cat jumpy-cat changed the title feat: add basic CI & doc deployments [feat](ci): add basic CI & doc deployments Aug 2, 2026
@jumpy-cat jumpy-cat changed the title [feat](ci): add basic CI & doc deployments feat(ci): add basic CI & doc deployments Aug 2, 2026
@jumpy-cat

jumpy-cat commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

The stuff that happened since the review was 90% git history cleanup, with the only real change a slight error message improvement to reminder tests. The flakiness due to firebase auth does happen, but very rarely. A fix can wait.

@jumpy-cat
jumpy-cat merged commit 59ad647 into dev Aug 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants