fix(Plugs.Cookies): avoid using other paths - #3385
Open
thecristen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Just happened to discover a few other "routes" stored in the cookie. :(
Implementation
It was thanks to poor path parsing. We have, for example,
/schedules/map_apiwhich one could hit. This would store "map_api" as a "route", which would eventually be looked up inRoutes.Repowhen rendering "Recently Visited" routes. Not great, and a waste of resources.The other aspect of this I wanted to raise is that, if you happen to have a nonsensical route in your cookie, this is going to be requested from the V3 API over and over and over. This is because we don't cache error responses. Normally that's a good thing, but in light of recognizing our website gets hammered with excess requests.... this creates a suboptimal situation. So I added an extra change in
Routes.Repowhich caches errors, but only for 30 seconds. Curious what folks think of that.Screenshots
No change!
How to test
The final test I added in the test file fails on
mainbut passes here!