refactor(Dotcom.PageController): avoid fetching and iterating all alerts ever - #3380
Draft
thecristen wants to merge 5 commits into
Draft
refactor(Dotcom.PageController): avoid fetching and iterating all alerts ever#3380thecristen wants to merge 5 commits into
thecristen wants to merge 5 commits into
Conversation
thecristen
force-pushed
the
cbj/homepage-alerts-rewrite
branch
from
July 31, 2026 18:38
2c80083 to
0aecec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
The homepage's "Alerts" tab shows routes and stops which have important alerts.
My local load testing on the homepage has found that fetching and processing alerts is by far the most computationally intensive part of the homepage. This PR tries to make that more performant.
Implementation
Screenshots
How to test