refactor(SystemStatus.CommuterRail): use service check - #3377
Open
thecristen wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This PR covers a few things I noticed while analyzing the homepage.
Implementation
Checking if a commuter rail route has service today
It's not directly related to the homepage, but as the system became overwhelmed and various things fell apart, one call that'd sometimes fail is this which feeds into the Commuter Rail Status widget:
This PR replaces this with the existing
Dotcom.ServicePatterns.has_service?/1function, which defaults to checking the current service date and uses a much simpler check (against V3 API/serviceresult rather than checking times in each result from/schedules).Getting alerts for each status widget
Both
subway_alert_groups()andcommuter_rail_alert_groups()currently fetch alerts by fetching all alerts then filtering the result down to the relevant routes. I realized we could start with fewer alerts by using the existingAlerts.Repo.by_route_types/2function. So that's what the final commit does.Screenshots
No change!
How to test
Compare with the current commuter rail status -- should work exactly the same way.