feat: Nicer /_flags page - #3371
Open
joshlarson wants to merge 5 commits into
Open
Conversation
joshlarson
added
do not merge
thecristen
reviewed
Jul 30, 2026
Comment on lines
+4
to
+7
| use Phoenix.VerifiedRoutes, | ||
| endpoint: DotcomWeb.Endpoint, | ||
| router: DotcomWeb.Router, | ||
| statics: DotcomWeb.static_paths() |
Collaborator
There was a problem hiding this comment.
FYI if you wanted to not need to include this, you can add this to the form
<input type="hidden" name="redirect" value={~p"/_flags"} />then in the controller can read the redirect param and do
|> redirect(to: params["redirect"])
…ead of the controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
No ticket, but I noticed that the helpful banner that tells you what environment you're in was missing from the
/_flagspage. I figured... while we're here, why not make it look pretty?Blocked by:
Screenshots
How to test
Go to the flags page, and toggle the flags as you see fit!