Move engine-strict from .npmrc to pnpm-workspace.yaml - #1743
Open
mm-jpoole wants to merge 1 commit into
Open
Conversation
pnpm 11 reads only auth and registry settings from .npmrc. Every other setting must live in pnpm-workspace.yaml or the global config, so engine-strict=true has been silently inactive since the pnpm 11 upgrade. Move it across as engineStrict: true and drop .npmrc, which held nothing else -- no registry or auth line. The impact of the dead setting was small: pnpm enforces this project's own engines field either way, and engineStrict only ever applied the node key to dependencies. Part of SCO-9212. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 11 reads only auth and registry settings from
.npmrc. Every other setting must live inpnpm-workspace.yamlor the global config, soengine-strict=truehas been silently inactive since the pnpm 11 upgrade.Confirmed in this checkout with pnpm 11.13.0:
pnpm config get engine-strictreturnedundefinedwhile.npmrcstill set it. After the change,pnpm config get engineStrictreturnstrue.This moves the setting across as
engineStrict: trueand drops.npmrc, which held nothing else — no registry or auth line. (mm_website keeps its.npmrcfor the Artifactoryregistry=line; this repo has no such line.)Impact of the dead setting was small: pnpm enforces this project's own
enginesfield either way, andengineStrictonly ever applied thenodekey to dependencies.Scope note:
ignoreScriptsandminimumReleaseAgeare deliberately not added here. They were never in this repo's.npmrcand belong with the mm_website part of the ticket.Verification
pnpm config get engineStrict—true(wasundefined)pnpm install --frozen-lockfile— clean,pnpm-lock.yamlunchangedpnpm run lint— passesprecious lint --all— passesPart of SCO-9212.
🤖 Generated with Claude Code