Skip to content

Move engine-strict from .npmrc to pnpm-workspace.yaml - #1743

Open
mm-jpoole wants to merge 1 commit into
mainfrom
jpoole/sco-9212-mm_website-pnpm-11-silently-ignores-ignore-scripts-and
Open

Move engine-strict from .npmrc to pnpm-workspace.yaml#1743
mm-jpoole wants to merge 1 commit into
mainfrom
jpoole/sco-9212-mm_website-pnpm-11-silently-ignores-ignore-scripts-and

Conversation

@mm-jpoole

Copy link
Copy Markdown
Contributor

pnpm 11 reads only auth and registry settings from .npmrc. Every other setting must live in pnpm-workspace.yaml or the global config, so engine-strict=true has been silently inactive since the pnpm 11 upgrade.

Confirmed in this checkout with pnpm 11.13.0: pnpm config get engine-strict returned undefined while .npmrc still set it. After the change, pnpm config get engineStrict returns true.

This moves the setting across as engineStrict: true and drops .npmrc, which held nothing else — no registry or auth line. (mm_website keeps its .npmrc for the Artifactory registry= line; this repo has no such line.)

Impact of the dead setting was small: pnpm enforces this project's own engines field either way, and engineStrict only ever applied the node key to dependencies.

Scope note: ignoreScripts and minimumReleaseAge are deliberately not added here. They were never in this repo's .npmrc and belong with the mm_website part of the ticket.

Verification

  • pnpm config get engineStricttrue (was undefined)
  • pnpm install --frozen-lockfile — clean, pnpm-lock.yaml unchanged
  • pnpm run lint — passes
  • precious lint --all — passes

Part of SCO-9212.

🤖 Generated with Claude Code

pnpm 11 reads only auth and registry settings from .npmrc. Every other
setting must live in pnpm-workspace.yaml or the global config, so
engine-strict=true has been silently inactive since the pnpm 11 upgrade.

Move it across as engineStrict: true and drop .npmrc, which held nothing
else -- no registry or auth line.

The impact of the dead setting was small: pnpm enforces this project's
own engines field either way, and engineStrict only ever applied the
node key to dependencies.

Part of SCO-9212.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: afef1e1d-4502-456b-bb3a-09abbcad02c8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant