SCO-9251 Point sign-up links at the create-account page - #1742
Merged
mm-jpoole merged 1 commit intoAug 31, 2026
Merged
Conversation
Two MaxMind marketing URLs now return 302: https://www.maxmind.com/en/geolite2/signup -> https://www.maxmind.com/en/create-account https://www.maxmind.com/en/request-service-trial?service_geoip=1 -> https://www.maxmind.com/en/create-account?service_geoip=1 lychee runs with max_redirects = 0 and does not accept 3xx, so every page carrying one of these links failed the Links CI job. Update all six source locations to the redirect targets, which return 200. The new page is the "Create an account" form, which covers both GeoIP trial requests and GeoLite sign-up, so the link text stays accurate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying dev-site with
|
| Latest commit: |
6a94940
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca257461.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://jpoole-sco-9251-redirecting.dev-site-4ua.pages.dev |
dhogan8
approved these changes
Aug 31, 2026
mm-jpoole
deleted the
jpoole/sco-9251-redirecting-maxmind-sign-up-links-on-the-dev-site-are-fixed
branch
August 31, 2026 21:49
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
LinksCI job.Two MaxMind marketing URLs now return
302, and lychee runs withmax_redirects = 0and does not accept 3xx status codes, so every page carrying one of them fails the build.https://www.maxmind.com/en/geolite2/signuphttps://www.maxmind.com/en/create-accounthttps://www.maxmind.com/en/request-service-trial?service_geoip=1https://www.maxmind.com/en/create-account?service_geoip=1Each old URL returns a single
302to the new URL. Each new URL returns200with no further redirect.The destination is MaxMind's "Create an account" form, which covers both GeoIP trial requests and GeoLite sign-up, so the existing link text stays accurate. Only the URL strings changed.
Six locations updated across five files. No change to
lychee.toml— an exclude would hide the stale URL instead of fixing it.Testing
Clean rebuild plus the same lychee invocation CI uses:
Result:
12250 Total, 2164 Unique, 12139 OK, 0 Errors, 111 Excluded.Prettier, cspell,
check-prettierignore-rawhtml,check-internal-links, andformat-rawhtmlall pass on the changed files.Linear: SCO-9251
🤖 Generated with Claude Code