Repository navigation
Plant: the feature range guard must fail on the old read - #3170
Draft
matrixarkai wants to merge 2 commits into
Draft
matrixarkai wants to merge 2 commits into
matrixarkai wants to merge 2 commits into
Conversation
…lock FeatureQuery and FeatureQueryFiltered copied each block out of the cache, decoded all of it into a vector of points, and cloned the wanted point out; the filtered read did that for every point in the window and dropped the ones the filters refused. Points are now read from the cached block's bytes, a block is walked once, and a value is copied only into a point the answer keeps. The window is still capped before the filters. The sequence read's guard now compares against a range read that keeps one value per point, since the range read no longer builds a point per point of the block. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The guard of the previous change must fail with the old counts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
matrixarkai
force-pushed
the
plant/a-feature-guard-must-fail-on-the-old-read
branch
from
November 16, 2026 02:54
ac864f0 to
fe68b9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch. It restores the replaced reads under the guards of #3161 so the guards are seen to fail with the old counts. Not for merge; closed once the failure is read.