Skip to content

Plant: the feature range guard must fail on the old read - #3170

Draft
matrixarkai wants to merge 2 commits into
mainfrom
plant/a-feature-guard-must-fail-on-the-old-read
Draft

matrixarkai wants to merge 2 commits into
mainfrom
plant/a-feature-guard-must-fail-on-the-old-read

Conversation

@matrixarkai

@matrixarkai matrixarkai commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Throwaway branch. It restores the replaced reads under the guards of #3161 so the guards are seen to fail with the old counts. Not for merge; closed once the failure is read.

superhaiou and others added 2 commits November 15, 2026 18:53
…lock

FeatureQuery and FeatureQueryFiltered copied each block out of the cache, decoded all of it
into a vector of points, and cloned the wanted point out; the filtered read did that for every
point in the window and dropped the ones the filters refused. Points are now read from the
cached block's bytes, a block is walked once, and a value is copied only into a point the
answer keeps. The window is still capped before the filters. The sequence read's guard now
compares against a range read that keeps one value per point, since the range read no longer
builds a point per point of the block.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The guard of the previous change must fail with the old counts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants