Skip to content

Plant: the string guard must fail on the old read - #3169

Draft
matrixarkai wants to merge 2 commits into
mainfrom
plant/a-string-guard-must-fail-on-the-old-read
Draft

matrixarkai wants to merge 2 commits into
mainfrom
plant/a-string-guard-must-fail-on-the-old-read

Conversation

@matrixarkai

@matrixarkai matrixarkai commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Throwaway branch. It restores the replaced read under the guard of #3160 so the guard is seen to fail with the old counts. Not for merge; closed once the failure is read.

superhaiou and others added 2 commits November 15, 2026 18:53
SET, SET NX, SET XX and SET KEEPTTL reach the shard as one conditional write, which read the
key's whole old value into a Vec before deciding anything and dropped it unread unless the
caller asked for it back. An unconditional write that returns nothing now reads nothing, and NX
and XX ask whether the key is there from its row, with no block read.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The guard of the previous change must fail with the old counts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants