Repository navigation
Plant: the string guard must fail on the old read - #3169
Draft
matrixarkai wants to merge 2 commits into
Draft
matrixarkai wants to merge 2 commits into
matrixarkai wants to merge 2 commits into
Conversation
SET, SET NX, SET XX and SET KEEPTTL reach the shard as one conditional write, which read the key's whole old value into a Vec before deciding anything and dropped it unread unless the caller asked for it back. An unconditional write that returns nothing now reads nothing, and NX and XX ask whether the key is there from its row, with no block read. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The guard of the previous change must fail with the old counts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
matrixarkai
force-pushed
the
plant/a-string-guard-must-fail-on-the-old-read
branch
from
November 16, 2026 02:54
1fde2d0 to
d7d8261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch. It restores the replaced read under the guard of #3160 so the guard is seen to fail with the old counts. Not for merge; closed once the failure is read.