Repository navigation
Move the matrixraft pin from 2c6929a to 70ff96f - #636
Merged
Merged
Conversation
The pin is 119 commits behind matrixraft's main. Move it, so this repository builds against the durable peer as it is now. Cargo.lock moves the matrixraft entry, adds the one new dependency edge it brings (rustix, Linux only, already in the tree through tempfile), and moves three Windows-only transitive dependency entries from windows-sys 0.52.0 to 0.61.2, which cargo chose while re-resolving. cargo check --all-features --all-targets is clean, the 222 cluster library tests pass, and so do the metadata and chunk consensus tests CI runs: the membership controller, star repair after a metadata failover, and the three dynamic-group tests that replace and rejoin voters. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
matrixraftpin from2c6929ato70ff96f, matrixraft's currentmain. The pin was 119 commits behind. No source change in this repository.What comes with it that this repository can feel
fsyncper write instead of two. A Ready that only advances the commit index is now written without a barrier of its own. After a crash a restart can find the stored commit index one write behind and recomputes it; an acknowledged entry is never lost this way. A clean reopen is unchanged.PeerLogReader::verify.set_flushed_indexandtrim_log_to(both refused for peers with durable membership, which the metadata and chunk consensus here use),set_early_packet_sink,closest_follower/transfer_leadership_to_closest,persisted_wal_barriers/persisted_wal_records, andPeerTuning::wal_preallocate_bytes. Nothing here changes behaviour until something calls them.Verified
On this branch with
--all-features:cargo check --all-targetschunk_membership_controllerthree_dynamic_groups_rejoin_removed_voters_across_three_roundsthree_dynamic_groups_replace_voters_during_reads_and_recoverthree_dynamic_groups_replace_voters_concurrently_during_reads_and_recoverstar_repairdbinary testsMeasured end to end (added after the merge)
This repository's own
network_chunk_consensusfixture starts threechunkserverprocesses with raft over TCP and a real WALfsyncon every replica. A scratch test that is not part of this change timed 200 sequential replicated 256-byte writes through the leader, 16 interleaved runs per variant, alternating which variant went first, each variant launching its ownchunkserver(the two binaries were checked to differ before any run).70ff96f)2c6929a)That is about 1.4x. The two losses were the first two runs, taken while the machine was under heavy I/O pressure with other builds running; the next ten pairs were all wins.
Caveats: a debug build; one disk shared with other work, whose I/O pressure drifted upward during the session (the absolute figures rose with it, which is why the runs were interleaved); sequential writes from a single client; one fixture. The single-voter matrixraft figure of about 2x does not carry over unchanged, because a replicated write also pays the network and the client round trips.
Lockfile
Besides the matrixraft entry, the lock adds the dependency edge
matrixraft -> rustix(Linux only;rustix 1.1.5was already in the tree throughtempfile) and moves three Windows-only transitive dependency entries fromwindows-sys 0.52.0to0.61.2, which cargo chose while re-resolving. Thewindows-sysmoves do not affect Linux builds.🤖 Generated with Claude Code