Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1570 +/- ##
========================================
Coverage 87.12% 87.12%
========================================
Files 392 392
Lines 89187 89187
Branches 5063 5063
========================================
Hits 77706 77706
+ Misses 11481 11461 -20
- Partials 0 20 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I am not sure I fully understand why this change is necessary and we should discuss this in more detail, but here is an initial brain dump: What loss of efficiency are you seeing exactly when you say pnpm always does a check of the node_modules. I am running |
That's odd, for me For me, when I run {
"scripts": {
"test": "echo done"
}
}and is otherwise empty, running Timing using So this is what I mean that |
|
I'm also using node v25.2.0, in case that makes a difference. |
|
I've tested with node v25.8.1 and with v26.10.0 after updating to the latest version. Both slower than pnpm. |
|
Not sure what to tell you. When I was trying to find out why |
That's actually due to a bad edit on my part. Line 125 in e3560be should actually be |
|
Closing this based on our discussion in the developers' meeting, and with the increased speed of pnpm version 12. |
This PR replaces
pnpm --silentwithnode --runin thepackage.jsonscripts. This is becausepnpmalways does a check of thenode_modulesdirectory for every call, somore --runis faster and more efficient. I had to make this change in the fonts repository because the latest versionofpnpmwas creating unwantednode_modulesdirectories in the font subdirectories, and was not finding thetscfrom the parentnode_modules, and the speed improvement was very noticeable, so I thought I'd try it here. You should see the commands that copy the locales and other assets run faster with this PR, for example.