Skip to content

Add tab key support to contextual menu, and add an aria-label (mathjax/MathJax#3609) #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpvc merged 2 commits into from
Sep 24, 2026
Merged

Add tab key support to contextual menu, and add an aria-label (mathjax/MathJax#3609) #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c1408
Add tab key support to contextual menu, and add an aria-label
dpvc Sep 16, 2026
83b3071
Remove leftover logging message
dpvc Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ts/ui/menu/MJContextMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,20 @@ export class MJContextMenu extends ContextMenu {
this.nofocus = false;
}

public keydown(event: KeyboardEvent) {
if (event.key === 'Tab') {
this.unpost();
}
super.keydown(event);
}

/*======================================================================*/

public generateHtml() {
super.generateHtml();
this.html.setAttribute('aria-label', localize('Title/Menu'));
}

/**
* Find an item in the menu (recursively descending into submenus, if needed)
*
Expand Down
1 change: 1 addition & 0 deletions ts/ui/menu/__locales__/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"Title/Annotation": "MathJax Annotationstext",
"Title/Braille": "MathJax Brailleschrift",
"Title/Error": "MathJax Fehlermeldung",
"Title/Menu": "MathJax Kontextmenü",
"Title/Mml": "MathJax MathML-Ausdruck",
"Title/Source": "MathJax original Quelltext",
"Title/Speech": "MathJax Sprachausgabe",
Expand Down
1 change: 1 addition & 0 deletions ts/ui/menu/__locales__/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"Title/Annotation": "MathJax Annotation Text",
"Title/Braille": "MathJax Braille Text",
"Title/Error": "MathJax Error Message",
"Title/Menu": "MathJax Contextual Menu",
"Title/Mml": "MathJax MathML Expression",
"Title/Source": "MathJax Original Source",
"Title/Speech": "MathJax Speech Text",
Expand Down
Loading