Skip to content

Adds @ts-ignore suppressions with TODO(go/ts60upgrade) for compiler #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Adds @ts-ignore suppressions with TODO(go/ts60upgrade) for compiler #6041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions testing/harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ import {
*
* @template H The harness type.
*/
export type HarnessElement<H extends Harness> = H extends Harness<infer E>
? ElementWithHarness<E, H>
: never;
export type HarnessElement<H extends Harness> =
H extends Harness<infer E> ? ElementWithHarness<E, H> : never;

/**
* Harnesses will attach themselves to their element for convenience.
Expand Down Expand Up @@ -898,6 +897,9 @@ export class Harness<E extends HTMLElement = HTMLElement> {
};

const superMatches = this.element.matches;
// TODO: go/ts60upgrade - Fix after TS 6.0 upgrade.
// TS2322: Type '(selector: string) => boolean' is not assignable to type '...'.
// @ts-ignore
element.matches = (selector: string) => {
return superMatches.call(element, getSelector(selector));
};
Expand Down
Loading