Repository navigation
fix(sv): truthful per-stream engineering scales, no-SCL 4I4V profile, safe power - #27
Merged
masarray merged 8 commits intoOct 16, 2026
Conversation
…nd truthful power
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…hority after capture reset
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0768e8644b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e three-phase totals
masarray
deleted the
fix/sv-engineering-scaling-and-field-diagnostics-20261016
branch
October 16, 2026 04:00
Owner
Author
Physical acceptance handoff — merged 2026-10-16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26 after independent Windows candidate acceptance.
Physical evidence / root cause
ESP32-P4 produced valid 4I+4V INT32 + quality payload and 4000 fps; raw receiver plotted dynamic wave/phasor without SCL. Metering incorrectly labelled raw
~1000current counts as~1000 A,~5774voltage counts as5.77 kV, and therefore invented MW/Mvar.Correct engineering boundary
I=0.001 A/countandU=0.01 V/count; no SCL required for bench profile, but UI warns this is operator-selected and not calibrated/proven by packets. Changes for one stream never apply to another.SvStreamState, raw samples and coherent windows. Scale multiplication only on UI snapshot projections, not per-packet hot path. No second decoder/cache. Consistent waveform series units and RMS/phasor units; no inconsistent MW on raw data.Guardrails
No capture or publisher commands, no customers' PCAP committed, no auto-universal IEC physical scaling, no hardware timing claims. Existing raw waveform, SCL matching, timing and receive-only architecture protected. Await repo health / dotnet solution test / Windows candidate CI before merge. Further bench tests with operator PCAP required for physical acceptance.