MLE-31723: fix publish image race - #469
Open
barkhachoithani wants to merge 2 commits into
Open
Conversation
…Ms and publishing wrong image versions
barkhachoithani
requested review from
Copilot,
pengzhouml,
rwinieski,
sumanthravipati and
vitalykorolev
July 31, 2026 23:28
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Jenkins pipeline to reduce race conditions during image publishing by tightening how build artifacts (RPMs/images) are selected and by avoiding ambiguous Docker image lookups in a shared-daemon environment.
Changes:
- Prefer version-scoped RPM filename patterns (with fallback) and add validation that the resolved RPM matches the requested MarkLogic major version.
- In the publish stage, rely only on the exact
builtImagetag (and verify it exists) instead of “grep-first-match” discovery fromdocker images. - Add explanatory inline comments clarifying why fully-qualified tags are required with concurrent builds on shared Docker daemons.
Comment on lines
+288
to
+291
| if (!RPM) { | ||
| error "No MarkLogic RPM found in src/ for architecture ${archSuffix}" | ||
| } | ||
|
|
Comment on lines
+295
to
+297
| if (!marklogicVersion.startsWith("${params.marklogicVersion}.")) { | ||
| error "Resolved RPM version '${marklogicVersion}' does not match requested marklogicVersion '${params.marklogicVersion}'" | ||
| } |
vitalykorolev
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Owner:
JIRA_ID as part of branch/PR name
Rebase the branch with upstream
Squashed all commits into a single commit
Added Tests
Reviewer:
Reviewed Tests
Added to Release Wiki/Jira