Skip to content

Finalize the 1.0.0-next.0 release candidate - #15

Merged
marklearst merged 4 commits into
mainfrom
agent/finalize-primitree-next-zero
Aug 17, 2026
Merged

marklearst merged 4 commits into
mainfrom
agent/finalize-primitree-next-zero

Conversation

@marklearst

@marklearst marklearst commented Aug 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • finalize 1.0.0-next.0 release dates before binding and tagging the exact main commit
  • preserve immutable release tags and make wrong-tag recovery fail closed
  • prevent deleted-tag events from entering npm publication or GitHub Release jobs

Verification

  • Node 24 release contracts: 84/84 passed
  • tag-mode metadata: six packages at 1.0.0-next.0
  • Prettier, Biome, public prose, shell syntax, and diff checks passed
  • independent code, prose, and release-safety review: clear

Copilot AI lite review requested due to automatic review settings August 17, 2026 03:47
@marklearst

Copy link
Copy Markdown
Owner Author

@codex review

@vercel

vercel Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
primitree Ready Ready Preview Aug 17, 2026 4:19am

Request Review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the 1.0.0-next.0 release candidate by locking in release-date copy, tightening wrong-tag recovery to preserve immutable tags, and hardening CI so tag-deletion events cannot trigger publication or GitHub Release creation.

Changes:

  • Guard publish and github-release jobs to skip deleted-tag push events.
  • Finalize and validate release runbook ordering (date copy before binding/tagging) and strengthen “wrong tag” recovery to fail closed.
  • Stamp the prerelease date across release notes and all package changelogs; update release-runbook verification tests accordingly.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/check-release.test.mjs Expands release/runbook and workflow contract tests (deleted-tag gating, recovery invariants, E404 checker behavior).
.github/workflows/ci.yml Adds deleted-tag event guard to prevent publish/release jobs from running on tag deletion pushes.
docs/releasing.md Updates release runbook to finalize dated release copy pre-binding, enforce immutable-tag recovery, and derive versions from verified artifacts.
docs/plans/2026-08-10-configured-dtcg-adoption.md Updates release plan step wording for review checks.
docs/launch/v1.0.0-next.0.md Marks the prerelease as “Released 2026-08-17.”
packages/core/CHANGELOG.md Dates the 1.0.0-next.0 entry.
packages/dtcg/CHANGELOG.md Dates the 1.0.0-next.0 entry.
packages/cli/CHANGELOG.md Dates the 1.0.0-next.0 entry.
packages/hooks/CHANGELOG.md Dates the 1.0.0-next.0 entry.
packages/mcp/CHANGELOG.md Dates the 1.0.0-next.0 entry.
packages/primitree/CHANGELOG.md Dates the 1.0.0-next.0 entry.
Suppressed comments (3)

docs/releasing.md:997

  • This step defines ARTIFACT_DIR=artifacts/npm, but the manifest path in the node -p command is still hard-coded. Using $ARTIFACT_DIR avoids duplication and keeps the snippet consistent with the variable.
VERSION=$(node -p "require('./artifacts/npm/manifest.json').version")

docs/releasing.md:1121

  • ARTIFACT_DIR is set in this block, but the manifest path is hard-coded. Consider using $ARTIFACT_DIR so the snippet stays correct if the artifact directory changes.
VERSION=$(node -p "require('./artifacts/npm/manifest.json').version")

docs/releasing.md:1171

  • This block sets ARTIFACT_DIR but still hard-codes ./artifacts/npm/manifest.json when extracting VERSION. Using $ARTIFACT_DIR removes duplication and keeps the commands consistent.
VERSION=$(node -p "require('./artifacts/npm/manifest.json').version")

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/releasing.md Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 413fd2d45a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/releasing.md Resolved
Comment thread scripts/check-release.test.mjs Resolved
@marklearst

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59330526e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/releasing.md Resolved
Comment thread docs/releasing.md Resolved
@marklearst

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 652286ce06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@marklearst

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 0548d9d261

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@marklearst
marklearst merged commit 1741070 into main Aug 17, 2026
6 checks passed
marklearst added a commit that referenced this pull request Aug 20, 2026
…zero

Finalize the 1.0.0-next.0 release candidate

This branch was successfully deployed

1 active deployment
Preview — 0548d9d2 Deployed Aug 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants