Add unit tests for video sampling, GPMF parser, and exiftool video reading #816
Merged
Conversation
caglarpir
force-pushed
the
dead-code-cleanup
branch
from
March 3, 2026 12:13
ca2de86 to
ee9ee87
Compare
caglarpir
force-pushed
the
improve-test-coverage
branch
from
March 3, 2026 12:13
85c966b to
b0f91ac
Compare
caglarpir
force-pushed
the
dead-code-cleanup
branch
from
March 3, 2026 13:35
ee9ee87 to
9305a95
Compare
caglarpir
force-pushed
the
improve-test-coverage
branch
from
March 3, 2026 13:35
b0f91ac to
568569d
Compare
caglarpir
force-pushed
the
dead-code-cleanup
branch
from
March 3, 2026 13:52
9305a95 to
bdb7a67
Compare
caglarpir
force-pushed
the
improve-test-coverage
branch
from
March 3, 2026 13:52
568569d to
993a832
Compare
…iftool video reading - sample_video: Add 20 tests for _within_track_time_range_buffered, _sample_video_stream_by_distance, rerun behavior, and end-to-end distance-based sampling with mocked ffmpeg/geotag/MP4 parsing - test_gpmf_parser: Expand GPMF parser test coverage; remove tests for extract_camera_model (removed in dead-code-cleanup) - test_exiftool_read_video: Add new test file for exiftool video reading
caglarpir
force-pushed
the
improve-test-coverage
branch
from
March 3, 2026 14:22
993a832 to
e17462f
Compare
in GPS parser functions
Reduce cyclomatic complexity in GPS parser functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_within_track_time_range_bufferedboundary logic,_sample_video_stream_by_distanceframe selection,sample_video()parameter validation and rerun behavior, and end-to-end integration with mocked ffmpeg/geotag/MP4 parsingparsing, telemetry extraction, and
extract_gopro_infointegration with real test datamake/model/serial extraction, and XML parsing for BlackVue, GoPro, and Insta360 formats
┌───────┬─────────────────┬───────────────────────┬───────────────────────────┐
│ │ main │ improve-test-coverage │ delta │
├───────┼─────────────────┼───────────────────────┼───────────────────────────┤
│ Total │ 59% (4496/7633) │ 64% (4884/7579) │ +5pp (+388 stmts covered) │
├───────┼─────────────────┼───────────────────────┼───────────────────────────┤
│ Tests │ 323 passed │ 540 passed │ +217 tests │
└───────┴─────────────────┴───────────────────────┴───────────────────────────┘