Skip to content

Wait for extraction to finish before reporting a download install complete #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
X-Guardian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wait for extraction to finish before reporting a download install complete #1009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,14 @@ function place_binary(uri, targetDir, opts, callback) {
log.info('install', `unpacking ${entry.path}`);
};

// resolve on extract close, not source end, so files are fully written before the caller loads them
dataStream.pipe(extract(targetDir, countExtractions))
.on('error', (e) => {
reject(e);
})
.on('close', () => {
resolve(`extracted file count: ${extractions}`);
});
dataStream.on('end', () => {
resolve(`extracted file count: ${extractions}`);
});
dataStream.on('error', (e) => {
reject(e);
});
Expand Down