fix: create-and-preview-style prompt now defaults to Standard, not streets-v12 - #134
Open
mattpodwysocki wants to merge 1 commit into
Open
fix: create-and-preview-style prompt now defaults to Standard, not streets-v12#134mattpodwysocki wants to merge 1 commit into
mattpodwysocki wants to merge 1 commit into
Conversation
…reets-v12
StyleBuilderTool has defaulted base_style to "standard" for a while now
("ALWAYS use 'standard' as the default for all new styles"), but this
prompt's own fallback and instructions were never updated to match: it
hardcoded streets-v12 and hand-authored a bare Classic-style JSON skeleton
directly in the prompt text, disconnected from the base_style argument
entirely (it never referenced it, and would have been structurally wrong
for a Standard-based style anyway, since Standard requires the imports/
config structure StyleBuilderTool already knows how to build).
Now defaults to "standard" and delegates style construction to
style_builder_tool, matching the pattern build-custom-map and other
prompts in this repo already use, instead of hand-rolling a Classic-only
skeleton in the prompt text.
Surfaced while reviewing whether mapbox/mcp-server#248/#250 (switching
render_map_tool to Standard, adding base-map restyling) implied any
follow-up here — they didn't (this repo's StyleBuilderTool/GeojsonPreview
were already Standard-first), but the check surfaced this pre-existing,
unrelated inconsistency.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Valiunia
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
create-and-preview-style'sbase_stylefallback and its "Create the map style" step now default to Standard, matchingStyleBuilderTool's own long-standing policy ("ALWAYS use 'standard' as the default for all new styles"), instead of hardcoding the Classicstreets-v12.Why
Noticed while checking whether mapbox/mcp-server#248/#250 (switching
render_map_toolto Standard, adding base-map restyling) implied any follow-up in this repo. They didn't —StyleBuilderToolandGeojsonPreviewUIResourcewere already Standard-first — but that check surfaced this prompt as a pre-existing, unrelated straggler that never got updated whenStyleBuilderTooladopted its "always default to standard" policy.It wasn't just the default string that was stale: the prompt's "Create the map style" step told the LLM to use the low-level
create_style_tooldirectly, with a hand-authored example JSON skeleton (sources/layersbackground fill) hardcoded in the prompt text — a bare Classic-style structure, completely disconnected from thebase_styleargument (it never referenced it). That example would have been structurally wrong for a Standard-based style regardless of what the default was, since Standard needs theimports/configstructurestyle_builder_toolalready knows how to build. So the fix also switches the prompt to the samestyle_builder_tool→create_style_tooltwo-step patternbuild-custom-mapand other prompts in this repo already use, rather than patching the default string on top of a hand-rolled example that was already wrong.Verification
"standard"(not"streets-v12") and referencesstyle_builder_tool; an explicit Classicbase_styleoverride is still respected.npx tsc --noEmit,npx eslint: clean.🤖 Generated with Claude Code