Skip to content

Add a Navigation help group and fix stale docs counts - #91

Merged
zmofei merged 4 commits into
mainfrom
fix/help-groups-navigation
Oct 9, 2026
Merged

zmofei merged 4 commits into
mainfrom
fix/help-groups-navigation

Conversation

@zmofei

@zmofei zmofei commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

CI on main fails because directions, isochrone, map-match and matrix have no help group or description since #83. This adds a Navigation group for them.

#82 was merged into this branch and lands with it. The last commit fixes what it left in docs/commands.md: the missing styles download entry, the commands that answer with bytes, and one old tilequery name.

Verified: fmt, clippy, tests; counts checked against mapbox --schema. Not run against the live API.

@zmofei zmofei added the locationai-team-skills Opened via the location-ai PR creation skill label Oct 9, 2026
@zmofei
zmofei marked this pull request as ready for review October 9, 2026 11:46
@zmofei
zmofei requested a review from a team as a code owner October 9, 2026 11:46
zmofei added 2 commits October 9, 2026 14:48
The renderer matched the service name tilequery, which #116 merged into
tilesets, so tilesets query has printed pretty JSON since 0.2.0. Match
tilesets, and check every listed name against the bundled specs so a
future rename fails a test instead of dropping the list.
@zmofei
zmofei added this pull request to stack #92 October 9, 2026 11:50
@zmofei
zmofei removed this pull request from stack #92 October 9, 2026 14:33
@zmofei
zmofei added this pull request to stack #93 October 9, 2026 14:33
Fix stale counts in docs and restore the tilesets query list

@mattpodwysocki mattpodwysocki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is what's currently blocking main: directions/isochrone/map-match/matrix landed after #83 added the help-group tests, so every_command_has_a_place, every_api_command_has_a_description and top_level_help_groups_commands_and_options are red on main right now. Rebuilt this branch and verified directly: the real --help output matches the Navigation block in the description exactly, the 39/13 operation and group counts in docs/commands.md check out against a real --schema run, and the tilequery->tilesets rename fix (with every_listed_service_is_a_real_command_group) is in here too. Full suite, fmt and clippy all pass.

This is also the fix PR #82 got stacked on, so merging this brings that one's content into main as well.

Approving, and merging now since this is unblocking CI on main for everyone.

@zmofei
zmofei removed this pull request from stack #93 October 9, 2026 15:50
@zmofei
zmofei merged commit f3b16ef into main Oct 9, 2026
8 checks passed
@zmofei zmofei changed the title Place the navigation commands in a Navigation help group Add a Navigation help group and fix stale docs counts Oct 9, 2026
@zmofei
zmofei requested review from jussi-sa and mattpodwysocki and removed request for jussi-sa and mattpodwysocki October 9, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

locationai-team-skills Opened via the location-ai PR creation skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants