Repository navigation
Conversation
zmofei
force-pushed
the
telemetry-config
branch
6 times, most recently
from
September 25, 2026 09:52
8e3914b to
70334bf
Compare
zmofei
force-pushed
the
telemetry-config
branch
from
September 28, 2026 09:23
70334bf to
4f86cc2
Compare
zmofei
force-pushed
the
telemetry-config
branch
from
September 28, 2026 11:35
4f86cc2 to
5c11060
Compare
zmofei
force-pushed
the
telemetry-config
branch
from
September 28, 2026 11:37
5c11060 to
e9c4922
Compare
zmofei
force-pushed
the
telemetry-config
branch
from
September 28, 2026 11:50
e9c4922 to
eb75a69
Compare
zmofei
added this pull request to stack #60
September 28, 2026 12:18
zmofei
force-pushed
the
telemetry-config
branch
from
September 28, 2026 12:21
eb75a69 to
a4e6eb5
Compare
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 09:56
a4e6eb5 to
3483d49
Compare
zmofei
removed this pull request from stack #60
October 9, 2026 09:57
zmofei
added this pull request to stack #88
October 9, 2026 09:57
zmofei
force-pushed
the
telemetry-config
branch
2 times, most recently
from
October 9, 2026 10:20
dd279a3 to
4643654
Compare
zmofei
removed this pull request from stack #88
October 9, 2026 11:34
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 11:34
4643654 to
d965c8f
Compare
zmofei
added this pull request to stack #90
October 9, 2026 11:34
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 11:50
d965c8f to
5fd5d39
Compare
zmofei
removed this pull request from stack #90
October 9, 2026 11:50
zmofei
added this pull request to stack #92
October 9, 2026 11:50
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 14:32
5fd5d39 to
aaa6f5e
Compare
zmofei
removed this pull request from stack #92
October 9, 2026 14:33
zmofei
added this pull request to stack #93
October 9, 2026 14:33
zmofei
force-pushed
the
telemetry-config
branch
5 times, most recently
from
October 9, 2026 15:30
173bc1d to
20d2fe9
Compare
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 15:37
20d2fe9 to
74ee02d
Compare
zmofei
changed the title
zmofei
marked this pull request as ready for review
October 9, 2026 15:49
zmofei
removed this pull request from stack #93
October 9, 2026 15:50
zmofei
added this pull request to stack #94
October 9, 2026 15:53
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 16:03
8d72758 to
2407fcc
Compare
zmofei
changed the title
mattpodwysocki
previously approved these changes
Oct 9, 2026
mattpodwysocki
left a comment
mattpodwysocki
left a comment
Contributor
There was a problem hiding this comment.
Verified the parts that matter most here rather than just reading the diff: ran the actual binary, confirmed mapbox config set telemetry off writes {"telemetry":false} to the real config.json and a fresh process reads it back, and that doctor reports telemetry_persisted/telemetry_allowed separately and correctly. Traced all three things it's supposed to gate, the event, the User-Agent markers, and the update-check, and confirmed each one actually checks the combined telemetry_allowed(), not just doctor's report of it. The key-by-key config.json parsing fix is real too: the old whole-struct Deserialize meant one bad key nulled everything, the new one isolates each key and keeps unknown ones on write, with tests that would catch a regression on either front.
The source_guards test stopping any other module from reading the env-only flag alone is a nice bit of insurance against exactly the bug class this PR is fixing.
Full suite, fmt, clippy all pass. Approving.
zmofei
dismissed
mattpodwysocki’s stale review
October 9, 2026 18:55
The merge-base changed after approval.
mapbox config set telemetry off stops the run's telemetry event in every shell, beside MAPBOX_CLI_NO_TELEMETRY for one. The setting is read again at exit, so the run that turns it off does not report itself.
The two opt-outs now mean the same thing, one for a shell and one for good: telemetry::telemetry_allowed reads both, so config set telemetry off also strips the User-Agent markers and silences the update notice, not only the event. mapbox doctor reports the setting as telemetry_persisted, with the reason in its text lines, and the Privacy section names it under How to Opt Out.
zmofei
force-pushed
the
telemetry-config
branch
from
October 9, 2026 18:55
2407fcc to
e35b817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #46.
Adds
mapbox config set telemetry off, which turns off the same things asMAPBOX_CLI_NO_TELEMETRY=1(event,User-Agentmarkers, update notice) in every shell.mapbox doctorreports it astelemetry_persisted.config.jsonis now read key by key, so one bad or unknown key no longer resets the opt-out. 0.3.0 still drops the key onconfig set; the CHANGELOG notes it.Verified: tests, each checked by breaking the code. Not verified: Windows locally.