environment: migrate more variables into repo_config_values - #14
Open
malon7782 wants to merge 2 commits into
Open
environment: migrate more variables into repo_config_values#14malon7782 wants to merge 2 commits into
malon7782 wants to merge 2 commits into
Conversation
Move the global 'pack_size_limit_cfg' configuration into the repository-specific 'repo_config_values' struct. We do not introduce a getter for it because the readers are limited and no hardcoded fallback values are needed. Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
Move the global 'assume_unchanged' configuration into the repository-specific 'repo_config_values' struct. We do not introduce a getter for it because the readers are limited and no hardcoded fallback values are needed. Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ca08a84a4b6a5fe9752745 Mon Sep 17 00:00:00 2001
From: Tian Yuchen cat@malon.dev
Date: Tue, 28 Jul 2026 09:34:34 +0800
Subject: [PATCH v2 0/2] environment: migrate more global variables into
repo_config_values, pt.2
Hi all,
This series moves:
into repo_config_values to continue the libification effort.
Change since v1:
Related:
https://lore.kernel.org/git/20260714032525.1611141-1-cat@malon.dev/#t
Thanks! yuchen
Tian Yuchen (2):
environment: migrate pack_size_limit_cfg into repo_config_values
environment: migrate assume_unchanged into repo_config_values
builtin/pack-objects.c | 2 +-
builtin/update-index.c | 3 ++-
environment.c | 8 ++++----
environment.h | 5 +++--
object-file.c | 5 +++--
read-cache.c | 9 ++++++---
6 files changed, 19 insertions(+), 13 deletions(-)
--
2.43.0