Repository navigation
feat: approve channel SSH egress through worker approval cards - #212
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent connecting to a public SSH server could only get a TLS proxy connection until an admin manually added the destination. Add
allow_channel_ssh_host, a durable approval card that any currently authorized member in a channel with write access may approve. The gateway appends the exact hostname without replacing existing hosts; Auto never supplies approval.The card discloses raw TCP ports 22, 5432 and 6543. Requester and approver authority, write mode, Network and public DNS are revalidated; existing per-request proxy protections remain in place. Updated the operating guide and registered private live acceptance definitions for both engines (pending).
Validation: full coverage suite 4,260 tests, 4,222 passed, 38 skipped, zero failures; aggregate lines 94.16%, branches 86.61%, functions 90.38%. Static and secret scans passed. Independent authorization review passed. Security coverage reports an existing modes.js authorization branch floor failure (92.39% vs 95%); that file and its area tests are unchanged. npm audit has no high/critical findings (four moderate). Live Slack approval/SSH acceptance remains pending.