Repository navigation
build: pin Hephaestus v1.3.0 - #4
Merged
Merged
Conversation
Move the Hephaestus action pins (e544acf, the commit of the v1.3.0 tag) and HEPHAESTUS_VERSION in the Makefile from v1.2.0 to v1.3.0 together, with the references that name the pinned release. v1.3.0 resolves the release branch of `hephaestus publish` (-branch, then preflight.branch, then the GitHub default branch) and adds the `default branch` and `release branch` checks; no preflight.branch is set here, so releases are still cut from main. The action, the plan and the artifacts are unchanged. Claude-Session: https://claude.ai/code/session_01RbGbwRHvCEhsKLZfbvbbRg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Hephaestus v1.2.0 → v1.3.0. The action pins move to
e544acf59c79cbafa04a48002b0f30f91a02f8ba # v1.3.0(the commit of the v1.3.0 tag, checked withgit ls-remote) andHEPHAESTUS_VERSIONin the Makefile tov1.3.0, in one change.v1.3.0's
hephaestus publishresolves the release branch (-branch, thenpreflight.branch, then the GitHub default branch) instead of assumingmain, and adds thedefault branchandrelease branchchecks. Nopreflight.branchis set inhephaestus.yaml, so releases are still cut frommain. The action, the plan outputs and the artifacts are unchanged.Changed:
.github/workflows/ci.yml,.github/workflows/release.yml(9 pins),Makefile,docs/development/releasing.md(the minimum installed Hephaestus forHEPHAESTUS=).References to v1.2.0 that describe history (what changed in v1.2.0) are left as they are. No release is made by this PR.
Verification
make check(lint, test, test-publish),make hephaestus-check,make actionlint,make renovate-check: pass.make snapshot: pass; asset and checksum names are those of the latest release v1.0.3 with the version replaced.make publish-check v1.0.4on this branch: fails only onbranch/in sync with origin/ CI of the unpushed commit (expected offmain; also the version check, asgit-parallel --versionis still v1.0.3);default branchandrelease branchresolve tomain.go run github.com/magicdrive/hephaestus@v1.3.0 publish check v1.0.4on a clone ofmain:default branch main (GitHub, origin/HEAD),release branch main (the default branch), preflight passed.https://claude.ai/code/session_01RbGbwRHvCEhsKLZfbvbbRg