Skip to content

Add Config Toggle to Show Confirmations in Visitor Map - #3428

Closed
PhillipHunter wants to merge 6 commits into
magicbug:devfrom
PhillipHunter:fix/visitor-gridmap-confirmations
Closed

Add Config Toggle to Show Confirmations in Visitor Map#3428
PhillipHunter wants to merge 6 commits into
magicbug:devfrom
PhillipHunter:fix/visitor-gridmap-confirmations

Conversation

@PhillipHunter

Copy link
Copy Markdown
Contributor

On the public visitor gridsquare and confirmations maps at /visitor/gridmap/<callsign>, I noticed that grids that the station operator has confirmed (via LoTW, eQSL, paper QSL, or QRZ.com) never appear as "confirmed" on the map, and stayed their red color.

It appears that the calls to the function for this did not have any of these services enabled for confirmation when called from the visitor page, causing this erroneous behavior.

I have since changed it to be true for these fields, allowing it to properly propagate those confirmations to the public page.

@PhillipHunter
PhillipHunter marked this pull request as draft April 20, 2026 03:22
@PhillipHunter

Copy link
Copy Markdown
Contributor Author

Pulling to draft and making this configurable, as I just noticed the comments regarding it being set to false, so I assume there was some intent there...

@PhillipHunter
PhillipHunter marked this pull request as ready for review April 20, 2026 04:40
@PhillipHunter

Copy link
Copy Markdown
Contributor Author

Added config setting for this, though I'm not sure why one would ever want that off. I'm not very familiar with the details of GDPR and such though.

@PhillipHunter PhillipHunter changed the title Fix Visitor Maps Not Showing Confirmations Add Config Toggle to Show Confirmations in Visitor Map Apr 20, 2026
@magicbug

Copy link
Copy Markdown
Owner

Nice idea, I am trying to avoid putting anything in config.php anymore and instead using the Global Options in Cloudlog, where the options are storeNice idea, I am trying to avoid putting anything in config.php anymore and instead using the Global Options in Cloudlog, where the options are stored in the database

This is using the OptionsLib library

// Example: set/update a global option
$this->load->library('OptionsLib');
$this->load->model('Options_model');

$optionName = 'my_feature_enabled';
$optionValue = '1'; // options are stored as strings
$autoload = 'yes'; // 'yes' or 'no'

if ($this->Options_model->item($optionName) === null) {
// Create new option
$this->optionslib->save($optionName, $optionValue, $autoload);
} else {
// Update existing option
$this->optionslib->update($optionName, $optionValue, $autoload);
}

Usually I create a migration to make the new option automatically exist

@PhillipHunter
PhillipHunter marked this pull request as draft April 22, 2026 05:16
@PhillipHunter
PhillipHunter marked this pull request as ready for review April 22, 2026 05:32
@PhillipHunter

PhillipHunter commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Updated and tested it with your suggestions, @magicbug . I'm not sure how you handle the language translation stuff though for the additional languages.

@magicbug
magicbug changed the base branch from master to dev August 14, 2026 11:48
@magicbug

Copy link
Copy Markdown
Owner

Thanks for this @PhillipHunter — I've rebased the work onto dev (we don't merge feature PRs into master) and finished the remaining bits:

  • Global Options via OptionsLib + a migration (now 278, since 267 was already used on dev)
  • Language strings for the other locales
  • Visitor gridmap calls now pass logbook locations after the satellite-orbit argument so public maps still query the right stations

Landed on dev in #3461 — closing this PR in favour of that merge.

@magicbug magicbug closed this Aug 14, 2026
phl0 pushed a commit to phl0/Cloudlog that referenced this pull request Aug 15, 2026
Rebase PR magicbug#3428 onto dev using OptionsLib and a migration, add language strings, and pass logbook locations after the satellite-orbit gridmap argument.

Co-authored-by: Phillip Hunter <phunter95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants